Add ProcessTypes, its test, and many proctype definition files

Add ProcessTypes, its test, and many proctype definition files.

TEST=util_test ProcessTypes.DyldImagesSelf
R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/30589d87a995

[Mark Mentovai, 2014-08-25 22:02:16]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Mark Mentovai, 2014-08-25 22:03:25]

Do you like macros?

[Robert Sesek, 2014-08-26 20:38:56]

This change is clever enough that I only reviewed it for correctness, rather
than looking for design suggestions/issues.

https://codereview.chromium.org/501203002/diff/1/util/mac/process_types.h
File util/mac/process_types.h (right):

https://codereview.chromium.org/501203002/diff/1/util/mac/process_types.h#new...
util/mac/process_types.h:66: /* Initializes an object with data read from
|process_reader| at           \
Why /* here instead of //! or just // ?

https://codereview.chromium.org/501203002/diff/1/util/mac/process_types/dyld_...
File util/mac/process_types/dyld_images.proctype (right):

https://codereview.chromium.org/501203002/diff/1/util/mac/process_types/dyld_...
util/mac/process_types/dyld_images.proctype:38: // structure’s actual size is
provided in PROCESS_TYPE_custom.cc. No
Just process_types/custom.cc

https://codereview.chromium.org/501203002/diff/1/util/mac/process_types/inter...
File util/mac/process_types/internal.h (right):

https://codereview.chromium.org/501203002/diff/1/util/mac/process_types/inter...
util/mac/process_types/internal.h:20: // Declare Traits_32 and Traits_64,
flavor-specific traits classes. These are
There's no _ in Traits names, and on line 22.

https://codereview.chromium.org/501203002/diff/1/util/mac/process_types/loade...
File util/mac/process_types/loader.proctype (right):

https://codereview.chromium.org/501203002/diff/1/util/mac/process_types/loade...
util/mac/process_types/loader.proctype:26: PROCESS_TYPE_STRUCT_MEMBER(int32_t,
cputype)
cputype is an integer_t which is an int (per mach/i386/vm_types.h). Per offline
discussion, this probably a safe assumption (int == int32_t), but it may be
worth a note?

[Mark Mentovai, 2014-08-26 20:48:34]

That’s cool, I’m glad that you normally ARE looking for opportunities for
improvement.

https://codereview.chromium.org/501203002/diff/1/util/mac/process_types.h
File util/mac/process_types.h (right):

https://codereview.chromium.org/501203002/diff/1/util/mac/process_types.h#new...
util/mac/process_types.h:66: /* Initializes an object with data read from
|process_reader| at           \
rsesek wrote:
> Why /* here instead of //! or just // ?

You can’t write a // comment inside a multi-line macro, because the // will
cause the preprocessor to ignore the \ at the end of the line, and then your
macro’s forced to end on that line.

I don’t think there’s a way to make Doxygen see these anyway because it’s not
really fully preprocessing things, so it’s just /* and not /*!.

[Robert Sesek, 2014-08-26 20:58:29]

LGTM

[Mark Mentovai, 2014-08-26 21:08:25]

Committed patchset #2 manually as 30589d87a995 (presubmit successful).