Issue 500138: [Mac] Implements popups for Page Actions, plus fixes a leak within the Browse...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 500138: [Mac] Implements popups for Page Actions, plus fixes a leak within the Browse... (Closed)

Created:
11 years ago by Bons

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai, Pam (message me for reviews)

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, John Grabowski, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Implements popups for Page Actions, plus fixes a leak within the Browser Action popup class. BUG=12281 TEST=Install the RSS feed page action extension. Go to a site with multiple feeds on the page, like http://ask.metafilter.com, observe a popup upon clicking the page action icon. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34992

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -13 lines)			Patch
M	chrome/browser/cocoa/extensions/browser_actions_controller.mm	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar_view_mac.h	View	4 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar_view_mac.mm	View	4 chunks	+26 lines, -6 lines	1 comment	Download
M	chrome/browser/extensions/extension_browser_event_router.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

lg http://codereview.chromium.org/500138/diff/1/5 File chrome/browser/cocoa/location_bar_view_mac.mm (right): http://codereview.chromium.org/500138/diff/1/5#newcode531 chrome/browser/cocoa/location_bar_view_mac.mm:531: arrowPoint.x += [GetImage() size].width / 2; NSWidth([GetImage() size]) ...

11 years ago (2009-12-18 21:37:25 UTC) #2

LGTM.

- Pam

Expand Messages | Collapse Messages