Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4686)

Unified Diff: chrome/browser/cocoa/location_bar_view_mac.h

Issue 500138: [Mac] Implements popups for Page Actions, plus fixes a leak within the Browse... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/location_bar_view_mac.h
===================================================================
--- chrome/browser/cocoa/location_bar_view_mac.h (revision 34960)
+++ chrome/browser/cocoa/location_bar_view_mac.h (working copy)
@@ -23,6 +23,7 @@
@class AutocompleteTextField;
class BubblePositioner;
class CommandUpdater;
+@class ExtensionPopupController;
class Profile;
class ToolbarModel;
@@ -83,6 +84,7 @@
virtual std::wstring GetTitle() const;
NSImage* GetTabButtonImage();
+ AutocompleteTextField* GetAutocompleteTextField() { return field_; }
// Internals of OnChanged(), pulled out for purposes of unit
// testing. Sets up |field| based on the parameters, which are
@@ -207,6 +209,7 @@
virtual void Observe(NotificationType type,
const NotificationSource& source,
const NotificationDetails& details);
+ void HidePopup();
// The location bar view that owns us.
LocationBarViewMac* owner_;
@@ -222,6 +225,9 @@
typedef std::map<std::string, SkBitmap> PageActionMap;
PageActionMap page_action_icons_;
+ // The controller for the popup displayed if a page action has one. Weak.
+ ExtensionPopupController* popupController_;
+
// The object that is waiting for the image loading to complete
// asynchronously.
ImageLoadingTracker* tracker_;

Powered by Google App Engine
This is Rietveld 408576698