Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2011)

Unified Diff: chrome/browser/cocoa/extensions/browser_actions_controller.mm

Issue 500138: [Mac] Implements popups for Page Actions, plus fixes a leak within the Browse... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/extensions/browser_actions_controller.mm
===================================================================
--- chrome/browser/cocoa/extensions/browser_actions_controller.mm (revision 34960)
+++ chrome/browser/cocoa/extensions/browser_actions_controller.mm (working copy)
@@ -441,11 +441,10 @@
// Adjust the anchor point to be at the center of the browser action button.
arrowPoint.x += kBrowserActionWidth / 2;
- popupController_ =
- [[ExtensionPopupController showURL:action->popup_url()
- inBrowser:browser_
- anchoredAt:arrowPoint
- arrowLocation:kTopRight] retain];
+ popupController_ = [ExtensionPopupController showURL:action->popup_url()
+ inBrowser:browser_
+ anchoredAt:arrowPoint
+ arrowLocation:kTopRight];
} else {
ExtensionBrowserEventRouter::GetInstance()->BrowserActionExecuted(
profile_, action->extension_id(), browser_);
« no previous file with comments | « no previous file | chrome/browser/cocoa/location_bar_view_mac.h » ('j') | chrome/browser/cocoa/location_bar_view_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698