Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 50004: * Made Date string parser reuse the same output array each time. (Closed)

Created:
11 years, 9 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Reuse output array instead of creating a new one for each call in Date.parse

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M src/date-delay.js View 2 chunks +3 lines, -2 lines 0 comments Download
M src/dateparser.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/dateparser-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +18 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Review, please.
11 years, 9 months ago (2009-03-19 08:24:13 UTC) #1
Erik Corry
11 years, 9 months ago (2009-03-19 09:09:19 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698