Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: src/dateparser-inl.h

Issue 50004: * Made Date string parser reuse the same output array each time. (Closed)
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/dateparser.h ('k') | src/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 11 matching lines...) Expand all
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 namespace v8 { namespace internal { 28 namespace v8 { namespace internal {
29 29
30 template <typename Char> 30 template <typename Char>
31 bool DateParser::Parse(Vector<Char> str, FixedArray* out) { 31 bool DateParser::Parse(Vector<Char> str, FixedArray* out) {
32 ASSERT(out->length() == OUTPUT_SIZE); 32 ASSERT(out->length() >= OUTPUT_SIZE);
33 InputReader<Char> in(str); 33 InputReader<Char> in(str);
34 TimeZoneComposer tz; 34 TimeZoneComposer tz;
35 TimeComposer time; 35 TimeComposer time;
36 DayComposer day; 36 DayComposer day;
37 37
38 while (!in.IsEnd()) { 38 while (!in.IsEnd()) {
39 if (in.IsAsciiDigit()) { 39 if (in.IsAsciiDigit()) {
40 // Parse a number (possibly with 1 or 2 trailing colons). 40 // Parse a number (possibly with 1 or 2 trailing colons).
41 int n = in.ReadUnsignedNumber(); 41 int n = in.ReadUnsignedNumber();
42 if (in.Skip(':')) { 42 if (in.Skip(':')) {
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 return false; 97 return false;
98 } else { 98 } else {
99 // Ignore other characters. 99 // Ignore other characters.
100 in.Next(); 100 in.Next();
101 } 101 }
102 } 102 }
103 return day.Write(out) && time.Write(out) && tz.Write(out); 103 return day.Write(out) && time.Write(out) && tz.Write(out);
104 } 104 }
105 105
106 } } // namespace v8::internal 106 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/dateparser.h ('k') | src/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698