src/dateparser-inl.h - Issue 50004: * Made Date string parser reuse the same output array each time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/dateparser-inl.h

Issue 50004: * Made Date string parser reuse the same output array each time. (Closed)

Patch Set: Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/dateparser-inl.h

diff --git a/src/dateparser-inl.h b/src/dateparser-inl.h

index ba5c0012054fd6c2bb68ac9f5a0ebdeefd5cc541..734c151d2559df691053183d9ff38ed901e8f4bf 100644

--- a/src/dateparser-inl.h

+++ b/src/dateparser-inl.h

@@ -29,7 +29,7 @@ namespace v8 { namespace internal {

template <typename Char>

bool DateParser::Parse(Vector<Char> str, FixedArray* out) {

- ASSERT(out->length() == OUTPUT_SIZE);

+ ASSERT(out->length() >= OUTPUT_SIZE);

InputReader<Char> in(str);

TimeZoneComposer tz;

TimeComposer time;

« no previous file with comments | « src/dateparser.h ('k') | src/runtime.h » ('j') | no next file with comments »