Minor code redundancy cleanup.

Minor code redundancy cleanup.

The RTCP sender API has reduntant information, getting rid of the redundencies means fewer lines of code.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291288

[Alpha Left Google, 2014-08-21 20:18:23]

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp.cc
File media/cast/net/rtcp/rtcp.cc (right):

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp.cc#...
media/cast/net/rtcp/rtcp.cc:209: // If RTCP is in compound mode then we always
send a RR.
This comment is invalid.

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp.cc#...
media/cast/net/rtcp/rtcp.cc:251: RtcpDlrrReportBlock dlrr;
DLRR can be removed from the code. It's not mandatory in the spec and receiver
doesn't use it. this and the entire if statement below can be removed.

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp_sen...
File media/cast/net/rtcp/rtcp_sender.cc (right):

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp_sen...
media/cast/net/rtcp/rtcp_sender.cc:188: if (dlrr)
DLRR can be removed.

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp_sen...
File media/cast/net/rtcp/rtcp_sender.h (right):

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp_sen...
media/cast/net/rtcp/rtcp_sender.h:63: const RtcpDlrrReportBlock* dlrr);
DLRR can be removed.

[hubbe, 2014-08-21 21:34:15]

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp.cc
File media/cast/net/rtcp/rtcp.cc (right):

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp.cc#...
media/cast/net/rtcp/rtcp.cc:209: // If RTCP is in compound mode then we always
send a RR.
On 2014/08/21 20:18:23, Alpha wrote:
> This comment is invalid.

Removed.

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp.cc#...
media/cast/net/rtcp/rtcp.cc:251: RtcpDlrrReportBlock dlrr;
On 2014/08/21 20:18:23, Alpha wrote:
> DLRR can be removed from the code. It's not mandatory in the spec and receiver
> doesn't use it. this and the entire if statement below can be removed.

Done.

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp_sen...
File media/cast/net/rtcp/rtcp_sender.cc (right):

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp_sen...
media/cast/net/rtcp/rtcp_sender.cc:188: if (dlrr)
On 2014/08/21 20:18:23, Alpha wrote:
> DLRR can be removed.

Done.

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp_sen...
File media/cast/net/rtcp/rtcp_sender.h (right):

https://codereview.chromium.org/499433002/diff/1/media/cast/net/rtcp/rtcp_sen...
media/cast/net/rtcp/rtcp_sender.h:63: const RtcpDlrrReportBlock* dlrr);
On 2014/08/21 20:18:23, Alpha wrote:
> DLRR can be removed.

Done.

[Alpha Left Google, 2014-08-21 21:38:12]

The CQ bit was checked by hclam@chromium.org

[Alpha Left Google, 2014-08-21 21:38:12]

lgtm

[commit-bot: I haz the power, 2014-08-21 21:41:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hubbe@chromium.org/499433002/20001

[commit-bot: I haz the power, 2014-08-21 23:11:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[commit-bot: I haz the power, 2014-08-22 01:08:10]

Committed patchset #2 (20001) as 291288