Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: media/cast/net/rtcp/rtcp_utility.cc

Issue 499433002: Minor code redundancy cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/net/rtcp/rtcp_unittest.cc ('k') | media/cast/net/rtcp/rtcp_utility_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/net/rtcp/rtcp_utility.cc
diff --git a/media/cast/net/rtcp/rtcp_utility.cc b/media/cast/net/rtcp/rtcp_utility.cc
index f6785f8814a0ff4b8d39518870e2b8368a552b92..a1a6a48c1d792e135ce1fc54cd93be5b3e579bfe 100644
--- a/media/cast/net/rtcp/rtcp_utility.cc
+++ b/media/cast/net/rtcp/rtcp_utility.cc
@@ -312,14 +312,6 @@ bool RtcpParser::ParseExtendedReport(base::BigEndianReader* reader,
return false;
break;
- case 5: // DLRR. RFC3611 Section 4.5.
- if (block_length % 3 != 0)
- return false;
- for (int block = 0; block < block_length / 3; block++)
- if (!ParseExtendedReportDelaySinceLastReceiverReport(reader))
- return false;
- return true;
-
default:
// Skip unknown item.
if (!reader->Skip(block_length * 4))
@@ -342,24 +334,6 @@ bool RtcpParser::ParseExtendedReportReceiverReferenceTimeReport(
return true;
}
-bool RtcpParser::ParseExtendedReportDelaySinceLastReceiverReport(
- base::BigEndianReader* reader) {
- uint32 ssrc, last_report, delay;
- if (!reader->ReadU32(&ssrc) ||
- !reader->ReadU32(&last_report) ||
- !reader->ReadU32(&delay))
- return false;
-
- if (ssrc == remote_ssrc_) {
- last_report_ = last_report;
- delay_since_last_report_ = delay;
- has_last_report_ = true;
- }
-
- has_last_report_ = true;
- return true;
-}
-
// Converts a log event type to an integer value.
// NOTE: We have only allocated 4 bits to represent the type of event over the
// wire. Therefore, this function can only return values from 0 to 15.
« no previous file with comments | « media/cast/net/rtcp/rtcp_unittest.cc ('k') | media/cast/net/rtcp/rtcp_utility_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698