Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: media/cast/net/rtcp/rtcp_sender.h

Issue 499433002: Minor code redundancy cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/cast/net/rtcp/rtcp.cc ('k') | media/cast/net/rtcp/rtcp_sender.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_CAST_NET_RTCP_RTCP_SENDER_H_ 5 #ifndef MEDIA_CAST_NET_RTCP_RTCP_SENDER_H_
6 #define MEDIA_CAST_NET_RTCP_RTCP_SENDER_H_ 6 #define MEDIA_CAST_NET_RTCP_RTCP_SENDER_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <list> 9 #include <list>
10 #include <string> 10 #include <string>
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 // of this class is to only to build a RTCP packet but not to send it. 44 // of this class is to only to build a RTCP packet but not to send it.
45 class RtcpSender { 45 class RtcpSender {
46 public: 46 public:
47 RtcpSender(PacedPacketSender* outgoing_transport, 47 RtcpSender(PacedPacketSender* outgoing_transport,
48 uint32 sending_ssrc); 48 uint32 sending_ssrc);
49 ~RtcpSender(); 49 ~RtcpSender();
50 50
51 // TODO(hclam): This method should be to build a packet instead of 51 // TODO(hclam): This method should be to build a packet instead of
52 // sending it. 52 // sending it.
53 void SendRtcpFromRtpReceiver( 53 void SendRtcpFromRtpReceiver(
54 uint32 packet_type_flags,
55 const RtcpReportBlock* report_block, 54 const RtcpReportBlock* report_block,
56 const RtcpReceiverReferenceTimeReport* rrtr, 55 const RtcpReceiverReferenceTimeReport* rrtr,
57 const RtcpCastMessage* cast_message, 56 const RtcpCastMessage* cast_message,
58 const ReceiverRtcpEventSubscriber::RtcpEventMultiMap* rtcp_events, 57 const ReceiverRtcpEventSubscriber::RtcpEventMultiMap* rtcp_events,
59 base::TimeDelta target_delay); 58 base::TimeDelta target_delay);
60 59
61 // TODO(hclam): This method should be to build a packet instead of 60 // TODO(hclam): This method should be to build a packet instead of
62 // sending it. 61 // sending it.
63 void SendRtcpFromRtpSender(uint32 packet_type_flags, 62 void SendRtcpFromRtpSender(const RtcpSenderInfo& sender_info);
64 const RtcpSenderInfo& sender_info,
65 const RtcpDlrrReportBlock& dlrr);
66 63
67 private: 64 private:
68 void BuildRR(const RtcpReportBlock* report_block, 65 void BuildRR(const RtcpReportBlock* report_block,
69 Packet* packet) const; 66 Packet* packet) const;
70 67
71 void AddReportBlocks(const RtcpReportBlock& report_block, 68 void AddReportBlocks(const RtcpReportBlock& report_block,
72 Packet* packet) const; 69 Packet* packet) const;
73 70
74 void BuildRrtr(const RtcpReceiverReferenceTimeReport* rrtr, 71 void BuildRrtr(const RtcpReceiverReferenceTimeReport* rrtr,
75 Packet* packet) const; 72 Packet* packet) const;
(...skipping 25 matching lines...) Expand all
101 98
102 std::deque<RtcpReceiverLogMessage> rtcp_events_history_; 99 std::deque<RtcpReceiverLogMessage> rtcp_events_history_;
103 100
104 DISALLOW_COPY_AND_ASSIGN(RtcpSender); 101 DISALLOW_COPY_AND_ASSIGN(RtcpSender);
105 }; 102 };
106 103
107 } // namespace cast 104 } // namespace cast
108 } // namespace media 105 } // namespace media
109 106
110 #endif // MEDIA_CAST_NET_RTCP_RTCP_SENDER_H_ 107 #endif // MEDIA_CAST_NET_RTCP_RTCP_SENDER_H_
OLDNEW
« no previous file with comments | « media/cast/net/rtcp/rtcp.cc ('k') | media/cast/net/rtcp/rtcp_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698