Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 497833003: <webview>: Add test coverage for deferred newwindow attachment. (Closed)

Created:
6 years, 4 months ago by lazyboy
Modified:
6 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

<webview>: Add test coverage for deferred newwindow attachment. We can trigger this case by adding a webview that is not in DOM through newwindow API. Fix so that deferred attachment would not throw error, this is done by returning true in attachWindow() method in this case. BUG=None Test=Load a <webview> in a chrome app. Make a newwindow request from that webview. When the newwindow event fires, call e.window.attach with a <webview> that is not on DOM, this should work as intended, when the later <webview> is attached to DOM, it should load properly. Committed: https://crrev.com/ed1bba31ff004bace7b9f479d1e3d75969142fa2 Cr-Commit-Position: refs/heads/master@{#291594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M chrome/browser/apps/web_view_interactive_browsertest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/web_view.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js View 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
lazyboy
6 years, 4 months ago (2014-08-22 20:33:56 UTC) #1
Fady Samuel
lgtm. Might be nice to have a test where we delete the opener while we ...
6 years, 4 months ago (2014-08-22 22:34:04 UTC) #2
lazyboy
On 2014/08/22 22:34:04, Fady Samuel wrote: > lgtm. > > Might be nice to have ...
6 years, 4 months ago (2014-08-22 22:53:38 UTC) #3
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 4 months ago (2014-08-23 00:04:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/497833003/1
6 years, 4 months ago (2014-08-23 00:05:15 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-23 06:53:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 1d2a45bba01e0ef30211cc96d876ef34d674493b
6 years, 4 months ago (2014-08-23 21:53:01 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:31:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed1bba31ff004bace7b9f479d1e3d75969142fa2
Cr-Commit-Position: refs/heads/master@{#291594}

Powered by Google App Engine
This is Rietveld 408576698