chrome/renderer/resources/extensions/web_view.js - Issue 497833003: <webview>: Add test coverage for deferred newwindow attachment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 497833003: <webview>: Add test coverage for deferred newwindow attachment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/web_view_interactive_browsertest.cc ('k') | chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/web_view.js

diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js

index 5f0cb6e5890750dd02b98e6c8e56e03c63127b90..f36662b81327925ad0cb063b4a188fbae295d967 100644

--- a/chrome/renderer/resources/extensions/web_view.js

+++ b/chrome/renderer/resources/extensions/web_view.js

@@ -866,7 +866,7 @@ WebViewInternal.prototype.attachWindow = function(guestInstanceId,

if (!this.isPluginInRenderTree()) {

this.deferredAttachState = {isNewWindow: isNewWindow};

- return false;

+ return true;

}

this.deferredAttachState = null;