Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: chrome/browser/apps/web_view_interactive_browsertest.cc

Issue 497833003: <webview>: Add test coverage for deferred newwindow attachment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/web_view.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/app_window.h" 5 #include "apps/app_window.h"
6 #include "apps/app_window_registry.h" 6 #include "apps/app_window_registry.h"
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/app/chrome_command_ids.h" 9 #include "chrome/app/chrome_command_ids.h"
10 #include "chrome/browser/apps/app_browsertest_util.h" 10 #include "chrome/browser/apps/app_browsertest_util.h"
(...skipping 745 matching lines...) Expand 10 before | Expand all | Expand 10 after
756 "web_view/newwindow", 756 "web_view/newwindow",
757 NEEDS_TEST_SERVER); 757 NEEDS_TEST_SERVER);
758 } 758 }
759 759
760 IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest, NewWindow_Close) { 760 IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest, NewWindow_Close) {
761 TestHelper("testNewWindowClose", 761 TestHelper("testNewWindowClose",
762 "web_view/newwindow", 762 "web_view/newwindow",
763 NEEDS_TEST_SERVER); 763 NEEDS_TEST_SERVER);
764 } 764 }
765 765
766 IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest, NewWindow_DeferredAttachment) {
767 TestHelper("testNewWindowDeferredAttachment",
768 "web_view/newwindow",
769 NEEDS_TEST_SERVER);
770 }
771
766 IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest, NewWindow_ExecuteScript) { 772 IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest, NewWindow_ExecuteScript) {
767 TestHelper("testNewWindowExecuteScript", 773 TestHelper("testNewWindowExecuteScript",
768 "web_view/newwindow", 774 "web_view/newwindow",
769 NEEDS_TEST_SERVER); 775 NEEDS_TEST_SERVER);
770 } 776 }
771 777
772 IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest, 778 IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest,
773 NewWindow_DeclarativeWebRequest) { 779 NewWindow_DeclarativeWebRequest) {
774 TestHelper("testNewWindowDeclarativeWebRequest", 780 TestHelper("testNewWindowDeclarativeWebRequest",
775 "web_view/newwindow", 781 "web_view/newwindow",
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
1100 1106
1101 // Now verify that the selection text propagates properly to RWHV. 1107 // Now verify that the selection text propagates properly to RWHV.
1102 content::RenderWidgetHostView* guest_rwhv = 1108 content::RenderWidgetHostView* guest_rwhv =
1103 guest_web_contents()->GetRenderWidgetHostView(); 1109 guest_web_contents()->GetRenderWidgetHostView();
1104 ASSERT_TRUE(guest_rwhv); 1110 ASSERT_TRUE(guest_rwhv);
1105 std::string selected_text = base::UTF16ToUTF8(guest_rwhv->GetSelectedText()); 1111 std::string selected_text = base::UTF16ToUTF8(guest_rwhv->GetSelectedText());
1106 ASSERT_TRUE(selected_text.size() >= 10u); 1112 ASSERT_TRUE(selected_text.size() >= 10u);
1107 ASSERT_EQ("AAAAAAAAAA", selected_text.substr(0, 10)); 1113 ASSERT_EQ("AAAAAAAAAA", selected_text.substr(0, 10));
1108 } 1114 }
1109 #endif 1115 #endif
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/web_view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698