IDL: Remove support for [LogPreviousValue] extended attribute

IDL: Remove support for [LogPreviousValue] extended attribute

Also remove the logSetter() overload taking an old value parameter from
the WebDOMActivityLogger interface, since there are no calls to it.

BUG=388287
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181643

[Jens Widell, 2014-08-27 11:57:39]

jl@opera.com changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[Jens Widell, 2014-08-27 11:57:39]

haraken@: I recall you said we were deprecating [LogPreviousValue]. It's no
longer used in any IDL file, so seems reasonable to remove it altogether.

tkent@: PTAL at public/ and Source/web/.

https://codereview.chromium.org/497773004/diff/1/public/web/WebDOMActivityLog...
File public/web/WebDOMActivityLogger.h (left):

https://codereview.chromium.org/497773004/diff/1/public/web/WebDOMActivityLog...
public/web/WebDOMActivityLogger.h:47: virtual void logSetter(const WebString&
apiName, const v8::Handle<v8::Value>& newValue, const v8::Handle<v8::Value>&
oldValue, const WebURL& url, const WebString& title) { }
This is implemented in extensions/renderer/dom_activity_logger.cc, but not using
OVERRIDE, so removing it here will not break compilation (or change behavior.)

[haraken, 2014-08-27 11:59:46]

haraken@chromium.org changed reviewers:
+ pmarch@chromium.org

[haraken, 2014-08-27 11:59:46]

LGTM

pmarch@: What's the status of the work of removing ActivityLogging code from the
binding layer? We were planning to remove as much ActivityLogging code as
possible, but is it already done?

[pmarch, 2014-08-27 12:31:40]

pmarch@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[pmarch, 2014-08-27 12:34:04]

On 2014/08/27 12:31:40, pmarch wrote:
> mailto:pmarch@chromium.org changed reviewers:
> + mailto:rdevlin.cronin@chromium.org

LGTM

added Devlin as FYI

[pmarch, 2014-08-27 12:38:51]

On 2014/08/27 11:59:46, haraken wrote:
> LGTM
> 
> pmarch@: What's the status of the work of removing ActivityLogging code from
the
> binding layer? We were planning to remove as much ActivityLogging code as
> possible, but is it already done?

I've finished with the ActivityLogging changes which are described in
https://docs.google.com/document/d/1yYiPPYasf-bAZvYpScmbiok9HJBFq2sol1YuvhVcR...

I've missed LogPreviousValue, thanks for cleaning this up.

[haraken, 2014-08-27 13:25:31]

On 2014/08/27 12:38:51, pmarch wrote:
> On 2014/08/27 11:59:46, haraken wrote:
> > LGTM
> > 
> > pmarch@: What's the status of the work of removing ActivityLogging code from
> the
> > binding layer? We were planning to remove as much ActivityLogging code as
> > possible, but is it already done?
> 
> I've finished with the ActivityLogging changes which are described in
>
https://docs.google.com/document/d/1yYiPPYasf-bAZvYpScmbiok9HJBFq2sol1YuvhVcR...

Thanks, great!

[pmarch, 2014-08-29 10:58:32]

On 2014/08/27 13:25:31, haraken wrote:
> On 2014/08/27 12:38:51, pmarch wrote:
> > On 2014/08/27 11:59:46, haraken wrote:
> > > LGTM
> > > 
> > > pmarch@: What's the status of the work of removing ActivityLogging code
from
> > the
> > > binding layer? We were planning to remove as much ActivityLogging code as
> > > possible, but is it already done?
> > 
> > I've finished with the ActivityLogging changes which are described in
> >
>
https://docs.google.com/document/d/1yYiPPYasf-bAZvYpScmbiok9HJBFq2sol1YuvhVcR...
> 
> Thanks, great!

Please check if this CL breaks any Activity Logger related browser_tests in
Chromium repo.

[Jens Widell, 2014-08-29 12:28:13]

On Fri, Aug 29, 2014 at 12:58 PM,  <pmarch@chromium.org> wrote:
> Please check if this CL breaks any Activity Logger related browser_tests in
> Chromium repo.

I've run "./browser_tests --gtest_filter=ActivityLog*", which passed.
Are there other related tests I should run?

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[pmarch, 2014-08-29 14:48:31]

On 2014/08/29 12:28:13, Jens Widell wrote:
> On Fri, Aug 29, 2014 at 12:58 PM,  <mailto:pmarch@chromium.org> wrote:
> > Please check if this CL breaks any Activity Logger related browser_tests in
> > Chromium repo.
> 
> I've run "./browser_tests --gtest_filter=ActivityLog*", which passed.
> Are there other related tests I should run?
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:blink-reviews+unsubscribe@chromium.org.

AdInjectionBrowserTest uses or used to use LogPreviousValue.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

[Jens Widell, 2014-08-29 14:54:05]

On 2014/08/29 14:48:31, pmarch wrote:
> On 2014/08/29 12:28:13, Jens Widell wrote:
> > On Fri, Aug 29, 2014 at 12:58 PM,  <mailto:pmarch@chromium.org> wrote:
> > > Please check if this CL breaks any Activity Logger related browser_tests
in
> > > Chromium repo.
> > 
> > I've run "./browser_tests --gtest_filter=ActivityLog*", which passed.
> > Are there other related tests I should run?
> > 
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:blink-reviews+unsubscribe@chromium.org.
> 
> AdInjectionBrowserTest uses or used to use LogPreviousValue.

Passed too.

[tkent, 2014-09-09 02:16:49]

The CQ bit was checked by tkent@chromium.org

[tkent, 2014-09-09 02:16:49]

lgtm

[commit-bot: I haz the power, 2014-09-09 02:17:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jl@opera.com/497773004/1

[commit-bot: I haz the power, 2014-09-09 02:18:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-09 02:18:05]

Failed to apply patch for Source/bindings/templates/attributes.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/templates/attributes.cpp
  Hunk #1 FAILED at 313.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/bindings/templates/attributes.cpp.rej

Patch:       Source/bindings/templates/attributes.cpp
Index: Source/bindings/templates/attributes.cpp
diff --git a/Source/bindings/templates/attributes.cpp
b/Source/bindings/templates/attributes.cpp
index
640fd79b1a286751a0dfb74bddd93ee04ee3cff2..c76fa2e3c937cfc8255875379dcedac6555076fd
100644
--- a/Source/bindings/templates/attributes.cpp
+++ b/Source/bindings/templates/attributes.cpp
@@ -313,16 +313,7 @@ v8::Local<v8::String>, v8::Local<v8::Value> v8Value, const
v8::PropertyCallbackI
     {% else %}
     if (contextData && contextData->activityLogger()) {
     {% endif %}
-        {% if attribute.activity_logging_include_old_value_for_setter %}
-        {{cpp_class}}* impl = {{v8_class}}::toNative(info.Holder());
-        {% if attribute.cpp_value_original %}
-        {{attribute.cpp_type}}
{{attribute.cpp_value}}({{attribute.cpp_value_original}});
-        {% endif %}
-        v8::Handle<v8::Value> originalValue =
{{attribute.cpp_value_to_v8_value}};
-       
contextData->activityLogger()->logSetter("{{interface_name}}.{{attribute.name}}",
v8Value, originalValue);
-        {% else %}
        
contextData->activityLogger()->logSetter("{{interface_name}}.{{attribute.name}}",
v8Value);
-        {% endif %}
     }
     {% endif %}
     {% if attribute.is_custom_element_callbacks or attribute.is_reflect %}

[Jens Widell, 2014-09-09 06:19:43]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-09-09 06:20:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jl@opera.com/497773004/20001

[commit-bot: I haz the power, 2014-09-09 09:05:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-09 09:05:59]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26155)

[Jens Widell, 2014-09-09 12:03:48]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-09-09 12:04:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jl@opera.com/497773004/40001

[commit-bot: I haz the power, 2014-09-09 13:08:30]

Committed patchset #3 (id:40001) as 181643