Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 497773004: IDL: Remove support for [LogPreviousValue] extended attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/tests/idls/core/TestObject.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/attributes.cpp
diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp
index 1969f6b72c980d1367830e47555121762a2ea6a8..a3bf28ee1eb039a5cd53b282d59ed4915d0d0b80 100644
--- a/Source/bindings/templates/attributes.cpp
+++ b/Source/bindings/templates/attributes.cpp
@@ -313,16 +313,7 @@ v8::Local<v8::String>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackI
{% else %}
if (contextData && contextData->activityLogger()) {
{% endif %}
- {% if attribute.activity_logging_include_old_value_for_setter %}
- {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
- {% if attribute.cpp_value_original %}
- {{attribute.cpp_type}} {{attribute.cpp_value}}({{attribute.cpp_value_original}});
- {% endif %}
- v8::Handle<v8::Value> originalValue = {{attribute.cpp_value_to_v8_value}};
- contextData->activityLogger()->logSetter("{{interface_name}}.{{attribute.name}}", v8Value, originalValue);
- {% else %}
contextData->activityLogger()->logSetter("{{interface_name}}.{{attribute.name}}", v8Value);
- {% endif %}
}
{% endif %}
{% if attribute.is_custom_element_callbacks or attribute.is_reflect %}
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/tests/idls/core/TestObject.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698