Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: Source/web/WebDOMActivityLogger.cpp

Issue 497773004: IDL: Remove support for [LogPreviousValue] extended attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/web/tests/ActivityLoggerTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 virtual void logGetter(const String& apiName) OVERRIDE 50 virtual void logGetter(const String& apiName) OVERRIDE
51 { 51 {
52 m_domActivityLogger->logGetter(WebString(apiName), getURL(), getTitle()) ; 52 m_domActivityLogger->logGetter(WebString(apiName), getURL(), getTitle()) ;
53 } 53 }
54 54
55 virtual void logSetter(const String& apiName, const v8::Handle<v8::Value>& n ewValue) OVERRIDE 55 virtual void logSetter(const String& apiName, const v8::Handle<v8::Value>& n ewValue) OVERRIDE
56 { 56 {
57 m_domActivityLogger->logSetter(WebString(apiName), newValue, getURL(), g etTitle()); 57 m_domActivityLogger->logSetter(WebString(apiName), newValue, getURL(), g etTitle());
58 } 58 }
59 59
60 virtual void logSetter(const String& apiName, const v8::Handle<v8::Value>& n ewValue, const v8::Handle<v8::Value>& oldValue) OVERRIDE
61 {
62 m_domActivityLogger->logSetter(WebString(apiName), newValue, oldValue, g etURL(), getTitle());
63 }
64
65 virtual void logMethod(const String& apiName, int argc, const v8::Handle<v8: :Value>* argv) OVERRIDE 60 virtual void logMethod(const String& apiName, int argc, const v8::Handle<v8: :Value>* argv) OVERRIDE
66 { 61 {
67 m_domActivityLogger->logMethod(WebString(apiName), argc, argv, getURL(), getTitle()); 62 m_domActivityLogger->logMethod(WebString(apiName), argc, argv, getURL(), getTitle());
68 } 63 }
69 64
70 virtual void logEvent(const String& eventName, int argc, const String* argv) OVERRIDE 65 virtual void logEvent(const String& eventName, int argc, const String* argv) OVERRIDE
71 { 66 {
72 Vector<WebString> webStringArgv; 67 Vector<WebString> webStringArgv;
73 for (int i = 0; i < argc; i++) 68 for (int i = 0; i < argc; i++)
74 webStringArgv.append(argv[i]); 69 webStringArgv.append(argv[i]);
(...skipping 23 matching lines...) Expand all
98 return V8DOMActivityLogger::activityLogger(worldId, extensionId); 93 return V8DOMActivityLogger::activityLogger(worldId, extensionId);
99 } 94 }
100 95
101 void setDOMActivityLogger(int worldId, const WebString& extensionId, WebDOMActiv ityLogger* logger) 96 void setDOMActivityLogger(int worldId, const WebString& extensionId, WebDOMActiv ityLogger* logger)
102 { 97 {
103 ASSERT(logger); 98 ASSERT(logger);
104 V8DOMActivityLogger::setActivityLogger(worldId, extensionId, adoptPtr(new DO MActivityLoggerContainer(adoptPtr(logger)))); 99 V8DOMActivityLogger::setActivityLogger(worldId, extensionId, adoptPtr(new DO MActivityLoggerContainer(adoptPtr(logger))));
105 } 100 }
106 101
107 } // namespace blink 102 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/web/tests/ActivityLoggerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698