Issue 497001: Add runFileChooser() with selected filenames and acceptable types parameters....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 497001: Add runFileChooser() with selected filenames and acceptable types parameters.... (Closed)

Created:
11 years ago by tkent

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), dglazkov

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Switch to runFileChooser() with WebFileChooserParams. New fields of WebFileChooserParams are not used yet. BUG=none TEST=none, no functional changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36335

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	chrome/renderer/render_view.h	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
	M	chrome/renderer/render_view.cc	View	1	3 chunks	+4 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

tkent

Commit plan: 1. Commit this to Chromium repository 2. Commit the WebKit part change to ...

11 years ago (2009-12-12 19:18:04 UTC) #1

tkent

Bug for the WebKit part: https://bugs.webkit.org/show_bug.cgi?id=32473

11 years ago (2009-12-12 20:02:42 UTC) #2

tkent

The WebKit part change was landed. Would you review this please?

10 years, 11 months ago (2010-01-15 06:05:46 UTC) #4

LGTM