Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6350)

Unified Diff: chrome/renderer/render_view.cc

Issue 497001: Add runFileChooser() with selected filenames and acceptable types parameters.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Switch to runFileChooser() with WebFileChooserParams.... Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/render_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_view.cc
===================================================================
--- chrome/renderer/render_view.cc (revision 36330)
+++ chrome/renderer/render_view.cc (working copy)
@@ -76,6 +76,7 @@
#include "third_party/WebKit/WebKit/chromium/public/WebDevToolsAgent.h"
#include "third_party/WebKit/WebKit/chromium/public/WebDocument.h"
#include "third_party/WebKit/WebKit/chromium/public/WebDragData.h"
+#include "third_party/WebKit/WebKit/chromium/public/WebFileChooserParams.h"
#include "third_party/WebKit/WebKit/chromium/public/WebFormElement.h"
#include "third_party/WebKit/WebKit/chromium/public/WebFrame.h"
#include "third_party/WebKit/WebKit/chromium/public/WebHistoryItem.h"
@@ -1589,9 +1590,7 @@
}
bool RenderView::runFileChooser(
- bool multi_select,
- const WebKit::WebString& title,
- const WebKit::WebString& initial_value,
+ const WebKit::WebFileChooserParams& params,
WebKit::WebFileChooserCompletion* chooser_completion) {
if (file_chooser_completion_) {
// TODO(brettw): bug 1235154: This should be a synchronous message to deal
@@ -1604,8 +1603,8 @@
}
file_chooser_completion_ = chooser_completion;
Send(new ViewHostMsg_RunFileChooser(
- routing_id_, multi_select, title,
- webkit_glue::WebStringToFilePath(initial_value)));
+ routing_id_, params.multiSelect, params.title,
+ webkit_glue::WebStringToFilePath(params.initialValue)));
return true;
}
« no previous file with comments | « chrome/renderer/render_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698