Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(26)

Issue 497001: Add runFileChooser() with selected filenames and acceptable types parameters.... (Closed)

Created:
10 years, 11 months ago by tkent
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam
Visibility:
Public.

Description

Switch to runFileChooser() with WebFileChooserParams. New fields of WebFileChooserParams are not used yet. BUG=none TEST=none, no functional changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36335

Patch Set 1 #

Patch Set 2 : Switch to runFileChooser() with WebFileChooserParams.... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M chrome/renderer/render_view.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
Commit plan: 1. Commit this to Chromium repository 2. Commit the WebKit part change to ...
10 years, 11 months ago (2009-12-12 19:18:04 UTC) #1
tkent
Bug for the WebKit part: https://bugs.webkit.org/show_bug.cgi?id=32473
10 years, 11 months ago (2009-12-12 20:02:42 UTC) #2
tkent
Add Dimitri as a reviewer.
10 years, 11 months ago (2009-12-21 08:34:54 UTC) #3
tkent
The WebKit part change was landed. Would you review this please?
10 years, 10 months ago (2010-01-15 06:05:46 UTC) #4
darin (slow to review)
10 years, 10 months ago (2010-01-15 06:33:16 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698