Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 496863003: Consolidate ExtensionAction execution code (Closed)

Created:
6 years, 4 months ago by Devlin
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Combine methods to execute extension actions into one place in ExtensionActionAPI. This also cleans up ExtensionToolbarModel and PageActionController, since they had too much knowledge about how to execute these actions. We also get to consolidate code in views, since now executing page and browser actions has a single API. Woohoo for -100 lines of code! BUG=406447 Committed: https://crrev.com/e9c71127d0d3bebe87ca105d557daf526f9d753c Cr-Commit-Position: refs/heads/master@{#291790}

Patch Set 1 : #

Patch Set 2 : Rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -283 lines) Patch
M chrome/browser/extensions/active_script_controller.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/active_script_controller.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/extensions/active_script_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/active_tab_apitest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.h View 1 2 3 chunks +16 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 2 5 chunks +89 lines, -72 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/page_action_apitest.cc View 1 3 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/extensions/error_console/error_console_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/browser/extensions/location_bar_controller.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/location_bar_controller.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/extensions/page_action_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/page_action_controller.cc View 1 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.h View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_action_view_controller.cc View 3 chunks +8 lines, -32 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Devlin
6 years, 4 months ago (2014-08-22 16:55:54 UTC) #1
Finnur
A little hard to follow at times and would have been good to see a ...
6 years, 4 months ago (2014-08-25 13:38:33 UTC) #2
Devlin
On 2014/08/25 13:38:33, Finnur wrote: > A little hard to follow at times and would ...
6 years, 4 months ago (2014-08-25 17:04:03 UTC) #3
Devlin
+avi for cocoa/
6 years, 4 months ago (2014-08-25 20:02:13 UTC) #4
Avi (use Gerrit)
Cocoa stuff LGTM. Trusting that the extensiony stuff in the Cocoa stuff is fine; I ...
6 years, 4 months ago (2014-08-25 20:14:46 UTC) #5
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-25 20:22:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/496863003/100001
6 years, 4 months ago (2014-08-25 20:24:22 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-25 21:30:45 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 22:39:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6661)
6 years, 4 months ago (2014-08-25 22:39:08 UTC) #10
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-25 22:45:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/496863003/100001
6 years, 4 months ago (2014-08-25 22:48:53 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (100001) as 9204a75e75ebbcb48f22c5badae361f07b3fc8aa
6 years, 4 months ago (2014-08-25 23:48:04 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:38:39 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e9c71127d0d3bebe87ca105d557daf526f9d753c
Cr-Commit-Position: refs/heads/master@{#291790}

Powered by Google App Engine
This is Rietveld 408576698