|
Combine methods to execute extension actions into one place
in ExtensionActionAPI. This also cleans up
ExtensionToolbarModel and PageActionController, since they
had too much knowledge about how to execute these actions.
We also get to consolidate code in views, since now executing
page and browser actions has a single API.
Woohoo for -100 lines of code!
BUG= 406447
Committed: https://crrev.com/e9c71127d0d3bebe87ca105d557daf526f9d753c
Cr-Commit-Position: refs/heads/master@{#291790}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+178 lines, -283 lines) |
Patch |
 |
M |
chrome/browser/extensions/active_script_controller.h
|
View
|
|
2 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/active_script_controller.cc
|
View
|
|
2 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/active_script_controller_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/active_tab_apitest.cc
|
View
|
|
3 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
|
View
|
|
4 chunks |
+11 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/extension_action/extension_action_api.h
|
View
|
1
2
|
3 chunks |
+16 lines, -20 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/extension_action/extension_action_api.cc
|
View
|
1
2
|
5 chunks |
+89 lines, -72 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/extension_action/page_action_apitest.cc
|
View
|
1
|
3 chunks |
+15 lines, -14 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/error_console/error_console_browsertest.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/extension_toolbar_model.h
|
View
|
1
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/extension_toolbar_model.cc
|
View
|
1
|
1 chunk |
+0 lines, -34 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/location_bar_controller.h
|
View
|
|
2 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/location_bar_controller.cc
|
View
|
|
1 chunk |
+0 lines, -21 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/page_action_controller.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/page_action_controller.cc
|
View
|
1
|
1 chunk |
+0 lines, -23 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/location_bar/page_action_decoration.h
|
View
|
|
3 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm
|
View
|
|
5 chunks |
+12 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/extensions/extension_action_view_controller.cc
|
View
|
|
3 chunks |
+8 lines, -32 lines |
0 comments
|
Download
|
Total messages: 14 (0 generated)
|