Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

Issue 496863003: Consolidate ExtensionAction execution code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
index 53b17197acb5ea2056cd72be28946c0542999fed..2b3882fe5442a296c14a0f34f491b5af3971a678 100644
--- a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
@@ -759,12 +759,13 @@ class ExtensionServiceObserverBridge
- (BOOL)browserActionClicked:(BrowserActionButton*)button
shouldGrant:(BOOL)shouldGrant {
const Extension* extension = [button extension];
- GURL popupUrl;
- switch (toolbarModel_->ExecuteBrowserAction(extension, browser_, &popupUrl,
- shouldGrant)) {
+ switch (extensions::ExtensionActionAPI::Get(profile_)->ExecuteExtensionAction(
+ extension, browser_, shouldGrant)) {
case ExtensionAction::ACTION_NONE:
break;
case ExtensionAction::ACTION_SHOW_POPUP: {
+ GURL popupUrl = extensions::ExtensionActionManager::Get(profile_)->
+ GetBrowserAction(*extension)->GetPopupUrl([self currentTabId]);
NSPoint arrowPoint = [self popupPointForBrowserAction:extension];
[ExtensionPopupController showURL:popupUrl
inBrowser:browser_
« no previous file with comments | « chrome/browser/extensions/page_action_controller.cc ('k') | chrome/browser/ui/cocoa/location_bar/page_action_decoration.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698