Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: chrome/browser/extensions/error_console/error_console_browsertest.cc

Issue 496863003: Consolidate ExtensionAction execution code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/error_console/error_console.h" 5 #include "chrome/browser/extensions/error_console/error_console.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
12 #include "chrome/browser/extensions/extension_browsertest.h" 13 #include "chrome/browser/extensions/extension_browsertest.h"
13 #include "chrome/browser/extensions/extension_toolbar_model.h"
14 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/common/pref_names.h" 15 #include "chrome/common/pref_names.h"
16 #include "chrome/common/url_constants.h" 16 #include "chrome/common/url_constants.h"
17 #include "chrome/test/base/ui_test_utils.h" 17 #include "chrome/test/base/ui_test_utils.h"
18 #include "extensions/browser/extension_error.h" 18 #include "extensions/browser/extension_error.h"
19 #include "extensions/common/constants.h" 19 #include "extensions/common/constants.h"
20 #include "extensions/common/error_utils.h" 20 #include "extensions/common/error_utils.h"
21 #include "extensions/common/extension.h" 21 #include "extensions/common/extension.h"
22 #include "extensions/common/extension_urls.h" 22 #include "extensions/common/extension_urls.h"
23 #include "extensions/common/feature_switch.h" 23 #include "extensions/common/feature_switch.h"
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 *extension = 242 *extension =
243 LoadExtensionWithFlags(test_data_dir_.AppendASCII(path), flags); 243 LoadExtensionWithFlags(test_data_dir_.AppendASCII(path), flags);
244 ASSERT_TRUE(*extension); 244 ASSERT_TRUE(*extension);
245 245
246 switch (action) { 246 switch (action) {
247 case ACTION_NAVIGATE: { 247 case ACTION_NAVIGATE: {
248 ui_test_utils::NavigateToURL(browser(), GetTestURL()); 248 ui_test_utils::NavigateToURL(browser(), GetTestURL());
249 break; 249 break;
250 } 250 }
251 case ACTION_BROWSER_ACTION: { 251 case ACTION_BROWSER_ACTION: {
252 ExtensionToolbarModel::Get(profile())->ExecuteBrowserAction( 252 ExtensionActionAPI::Get(profile())->ExecuteExtensionAction(
253 *extension, browser(), NULL, true); 253 *extension, browser(), true);
254 break; 254 break;
255 } 255 }
256 case ACTION_NEW_TAB: { 256 case ACTION_NEW_TAB: {
257 ui_test_utils::NavigateToURL(browser(), 257 ui_test_utils::NavigateToURL(browser(),
258 GURL(chrome::kChromeUINewTabURL)); 258 GURL(chrome::kChromeUINewTabURL));
259 break; 259 break;
260 } 260 }
261 case ACTION_NONE: 261 case ACTION_NONE:
262 break; 262 break;
263 default: 263 default:
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
575 575
576 const StackTrace& stack_trace = GetStackTraceFromError(errors[0]); 576 const StackTrace& stack_trace = GetStackTraceFromError(errors[0]);
577 ASSERT_EQ(1u, stack_trace.size()); 577 ASSERT_EQ(1u, stack_trace.size());
578 CheckStackFrame(stack_trace[0], 578 CheckStackFrame(stack_trace[0],
579 script_url, 579 script_url,
580 kAnonymousFunction, 580 kAnonymousFunction,
581 12u, 20u); 581 12u, 20u);
582 } 582 }
583 583
584 } // namespace extensions 584 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698