UMA: How often are different network error screens encountered during OOBE

chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc

Index: chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
diff --git a/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc b/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
index f786bbed4485d640af7b1f8599bf7b84014fd197..0529346ee96c6e5572f98fcfbbea17a0911cce54 100644
--- a/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
+++ b/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
@@ -8,6 +8,7 @@
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/logging.h"
+#include "chrome/browser/chromeos/login/error_screens_histogram_helper.h"
 #include "chrome/browser/chromeos/login/screens/screen_observer.h"
 #include "chrome/browser/chromeos/login/wizard_controller.h"
 #include "chromeos/chromeos_switches.h"
@@ -23,7 +24,8 @@ AutoEnrollmentCheckScreen::AutoEnrollmentCheckScreen(
       actor_(actor),
       captive_portal_status_(
           NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_UNKNOWN),
-      auto_enrollment_state_(policy::AUTO_ENROLLMENT_STATE_IDLE) {
+      auto_enrollment_state_(policy::AUTO_ENROLLMENT_STATE_IDLE),
+      histogram_helper_(new ErrorScreensHistogramHelper("Enrollment")) {
   if (actor_)
     actor_->SetDelegate(this);
 }
@@ -77,6 +79,7 @@ void AutoEnrollmentCheckScreen::Show() {
     Start();
     if (actor_)
       actor_->Show();
+    histogram_helper_->OnScreenShow();
   }
 }
 
@@ -211,6 +214,7 @@ void AutoEnrollmentCheckScreen::ShowErrorScreen(
   error_screen->SetErrorState(error_state,
                               network ? network->name() : std::string());
   get_screen_observer()->ShowErrorScreen();
+  histogram_helper_->OnErrorShow(error_screen->GetErrorState());

[ygorshenin1, 2014/08/26 14:33:13]

nit: I suggest you to replace ErrorScreen::GetErrorState() call by the
error_state, because if someone occasionally will move the line before the call
to ErrorScreen::SetErrorState(), incorrect error state will be reported.

[Roman Sorokin (ftl), 2014/09/04 13:26:47]

Done.

 }
 
 void AutoEnrollmentCheckScreen::SignalCompletion() {