UMA: How often are different network error screens encountered during OOBE

chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/logging.h"
+#include "chrome/browser/chromeos/login/error_screens_histogram_helper.h"
 #include "chrome/browser/chromeos/login/screens/screen_observer.h"
 #include "chrome/browser/chromeos/login/wizard_controller.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/network/network_state.h"
 #include "chromeos/network/network_state_handler.h"
 
 namespace chromeos {
 
 AutoEnrollmentCheckScreen::AutoEnrollmentCheckScreen(
     ScreenObserver* observer,
     AutoEnrollmentCheckScreenActor* actor)
     : WizardScreen(observer),
       actor_(actor),
       captive_portal_status_(
           NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_UNKNOWN),
-      auto_enrollment_state_(policy::AUTO_ENROLLMENT_STATE_IDLE) {
+      auto_enrollment_state_(policy::AUTO_ENROLLMENT_STATE_IDLE),
+      histogram_helper_(new ErrorScreensHistogramHelper("Enrollment")) {
   if (actor_)
     actor_->SetDelegate(this);
 }
 
 AutoEnrollmentCheckScreen::~AutoEnrollmentCheckScreen() {
   NetworkPortalDetector::Get()->RemoveObserver(this);
   if (actor_)
     actor_->SetDelegate(NULL);
 }
 
@@ skipping 33 matching lines @@
 }
 
 void AutoEnrollmentCheckScreen::PrepareToShow() {
 }
 
 void AutoEnrollmentCheckScreen::Show() {
   if (IsStartNeeded()) {
     Start();
     if (actor_)
       actor_->Show();
+    histogram_helper_->OnScreenShow();
   }
 }
 
 void AutoEnrollmentCheckScreen::Hide() {
 }
 
 std::string AutoEnrollmentCheckScreen::GetName() const {
   return WizardController::kAutoEnrollmentCheckScreenName;
 }
 
@@ skipping 114 matching lines @@
 void AutoEnrollmentCheckScreen::ShowErrorScreen(
     ErrorScreen::ErrorState error_state) {
   const NetworkState* network =
       NetworkHandler::Get()->network_state_handler()->DefaultNetwork();
   ErrorScreen* error_screen = get_screen_observer()->GetErrorScreen();
   error_screen->SetUIState(ErrorScreen::UI_STATE_AUTO_ENROLLMENT_ERROR);
   error_screen->AllowGuestSignin(true);
   error_screen->SetErrorState(error_state,
                               network ? network->name() : std::string());
   get_screen_observer()->ShowErrorScreen();
+  histogram_helper_->OnErrorShow(error_screen->GetErrorState());

[ygorshenin1, 2014/08/26 14:33:13]

nit: I suggest you to replace ErrorScreen::GetErrorState() call by the
error_state, because if someone occasionally will move the line before the call
to ErrorScreen::SetErrorState(), incorrect error state will be reported.

[Roman Sorokin (ftl), 2014/09/04 13:26:47]

Done.

 }
 
 void AutoEnrollmentCheckScreen::SignalCompletion() {
   NetworkPortalDetector::Get()->RemoveObserver(this);
   auto_enrollment_progress_subscription_.reset();
   get_screen_observer()->OnExit(
       ScreenObserver::ENTERPRISE_AUTO_ENROLLMENT_CHECK_COMPLETED);
 }
 
 }  // namespace chromeos