Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: chrome/browser/chromeos/login/error_screens_histogram_helper.h

Issue 494633003: UMA: How often are different network error screens encountered during OOBE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/error_screens_histogram_helper.h
diff --git a/chrome/browser/chromeos/login/error_screens_histogram_helper.h b/chrome/browser/chromeos/login/error_screens_histogram_helper.h
new file mode 100644
index 0000000000000000000000000000000000000000..0f7f70632a559c467310dc9283cc4444df788898
--- /dev/null
+++ b/chrome/browser/chromeos/login/error_screens_histogram_helper.h
@@ -0,0 +1,41 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_ERROR_SCREENS_HISTOGRAM_HELPER_H_
+#define CHROME_BROWSER_CHROMEOS_LOGIN_ERROR_SCREENS_HISTOGRAM_HELPER_H_
+
+#include "chrome/browser/chromeos/login/screens/error_screen.h"
+
+namespace chromeos {
+FORWARD_DECLARE_TEST(ErrorScreensHistogramHelperTest, TestShowHideTime);
+FORWARD_DECLARE_TEST(ErrorScreensHistogramHelperTest, TestShowHideShowHideTime);
+FORWARD_DECLARE_TEST(ErrorScreensHistogramHelperTest, TestShowShowHideTime);
+
+class ErrorScreensHistogramHelper {
+ public:
+ explicit ErrorScreensHistogramHelper(const char* screen_name);
ygorshenin1 2014/08/26 14:33:14 nit: replace const char* by const std::string&.
Roman Sorokin (ftl) 2014/09/04 13:26:47 Done.
+ void OnScreenShow();
+ void OnErrorShow(ErrorScreen::ErrorState error);
+ void OnErrorHide();
+ ~ErrorScreensHistogramHelper();
+
+ private:
+ FRIEND_TEST_ALL_PREFIXES(ErrorScreensHistogramHelperTest, TestShowHideTime);
+ FRIEND_TEST_ALL_PREFIXES(ErrorScreensHistogramHelperTest,
+ TestShowHideShowHideTime);
+ FRIEND_TEST_ALL_PREFIXES(ErrorScreensHistogramHelperTest,
+ TestShowShowHideTime);
+ // functions for testing.
+ void OnErrorShowTime(ErrorScreen::ErrorState error, base::Time now);
+ void OnErrorHideTime(base::Time now);
ygorshenin1 2014/08/26 14:33:14 nit: add a blank line between methods and fields.
Roman Sorokin (ftl) 2014/09/04 13:26:47 Done.
+ std::string screen_name_;
+ bool was_shown_;
+ ErrorScreen::ErrorState last_error_shown_;
+ base::Time error_screen_start_time;
+ base::TimeDelta time_on_error_screens;
+};
+
+} // namespace chromeos
+
+#endif // CHROME_BROWSER_CHROMEOS_LOGIN_ERROR_SCREENS_HISTOGRAM_HELPER_H_

Powered by Google App Engine
This is Rietveld 408576698