Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 494633002: Fix implementation of bit count functions. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Fix implementation of bit count functions. The bit counting functions provided by CompilerIntrinsics were undefined for zero, which was easily overlooked and unsafe in general. Also their implementation was kinda hacky and mostly untested. Fixed the implementation and moved the functions to base/bits.h. TEST=base-unittests,cctest,compiler-unittests,mjsunit R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -114 lines) Patch
M include/v8config.h View 3 chunks +9 lines, -0 lines 0 comments Download
M src/base/bits.h View 2 chunks +58 lines, -0 lines 0 comments Download
D src/compiler-intrinsics.h View 1 chunk +0 lines, -73 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M src/data-flow.h View 3 chunks +4 lines, -11 lines 0 comments Download
M src/data-flow.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M src/frames.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/heap/mark-compact.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/simulator-mips.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M test/base-unittests/bits-unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 4 months ago (2014-08-20 12:03:44 UTC) #1
Hannes Payer (out of office)
lgtm (rubber-stamped)
6 years, 4 months ago (2014-08-20 12:09:28 UTC) #2
Benedikt Meurer
6 years, 4 months ago (2014-08-20 12:10:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23229 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698