|
Fix implementation of bit count functions.
The bit counting functions provided by CompilerIntrinsics were undefined
for zero, which was easily overlooked and unsafe in general. Also their
implementation was kinda hacky and mostly untested. Fixed the
implementation and moved the functions to base/bits.h.
TEST=base-unittests,cctest,compiler-unittests,mjsunit
R=hpayer@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=23229
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+137 lines, -114 lines) |
Patch |
|
M |
include/v8config.h
|
View
|
|
3 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/base/bits.h
|
View
|
|
2 chunks |
+58 lines, -0 lines |
0 comments
|
Download
|
|
D |
src/compiler-intrinsics.h
|
View
|
|
1 chunk |
+0 lines, -73 lines |
0 comments
|
Download
|
|
M |
src/compiler/arm/instruction-selector-arm.cc
|
View
|
|
4 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
|
M |
src/data-flow.h
|
View
|
|
3 chunks |
+4 lines, -11 lines |
0 comments
|
Download
|
|
M |
src/data-flow.cc
|
View
|
|
2 chunks |
+14 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/frames.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
src/heap/mark-compact.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
src/heap/mark-compact.cc
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/hydrogen-instructions.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/mips/simulator-mips.cc
|
View
|
|
3 chunks |
+3 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/mips64/simulator-mips64.cc
|
View
|
|
3 chunks |
+3 lines, -6 lines |
0 comments
|
Download
|
|
M |
test/base-unittests/bits-unittest.cc
|
View
|
|
1 chunk |
+30 lines, -0 lines |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|