src/runtime.cc - Issue 494153002: Avoid one repeated property lookup when computing store ICs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 494153002: Avoid one repeated property lookup when computing store ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments (triggering a bug in doing so) Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 3ebd6b5b7e9fbf31cbcb818eb2fdc5a2f3a94c1a..f1e4826d8c25b5ec7904b08292c8432834aaa1f7 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -10881,6 +10881,7 @@ static Handle<Object> DebugLookupResultValue(LookupIterator* it,

for (; it->IsFound(); it->Next()) {

switch (it->state()) {

case LookupIterator::NOT_FOUND:

+ case LookupIterator::TRANSITION:

UNREACHABLE();

case LookupIterator::ACCESS_CHECK:

// Ignore access checks.

« no previous file with comments | « src/objects.cc ('k') | src/stub-cache.h » ('j') | no next file with comments »