src/stub-cache.h - Issue 494153002: Avoid one repeated property lookup when computing store ICs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/stub-cache.h

Issue 494153002: Avoid one repeated property lookup when computing store ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments (triggering a bug in doing so) Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/stub-cache.h

diff --git a/src/stub-cache.h b/src/stub-cache.h

index d8aafdf07e4f7c37ed5ea87a68999113115f8284..992cd9c4df12aef1b18d6373b260528fd90ee602 100644

--- a/src/stub-cache.h

+++ b/src/stub-cache.h

@@ -558,7 +558,7 @@ class NamedStoreHandlerCompiler : public PropertyHandlerCompiler {

Handle<Code> CompileStoreTransition(Handle<Map> transition,

Handle<Name> name);

- Handle<Code> CompileStoreField(LookupResult* lookup, Handle<Name> name);

+ Handle<Code> CompileStoreField(LookupIterator* lookup, Handle<Name> name);

Handle<Code> CompileStoreCallback(Handle<JSObject> object, Handle<Name> name,

Handle<ExecutableAccessorInfo> callback);

Handle<Code> CompileStoreCallback(Handle<JSObject> object, Handle<Name> name,

@@ -590,7 +590,7 @@ class NamedStoreHandlerCompiler : public PropertyHandlerCompiler {

Label* miss_label, Label* slow);

- void GenerateStoreField(LookupResult* lookup, Register value_reg,

+ void GenerateStoreField(LookupIterator* lookup, Register value_reg,

Label* miss_label);

static Builtins::Name SlowBuiltin(Code::Kind kind) {

« no previous file with comments | « src/runtime.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »