Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: src/runtime.cc

Issue 494153002: Avoid one repeated property lookup when computing store ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments (triggering a bug in doing so) Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/stub-cache.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdlib.h> 5 #include <stdlib.h>
6 #include <limits> 6 #include <limits>
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/accessors.h" 10 #include "src/accessors.h"
(...skipping 10863 matching lines...) Expand 10 before | Expand all | Expand 10 after
10874 isolate->stack_guard()->RequestDebugBreak(); 10874 isolate->stack_guard()->RequestDebugBreak();
10875 return isolate->heap()->undefined_value(); 10875 return isolate->heap()->undefined_value();
10876 } 10876 }
10877 10877
10878 10878
10879 static Handle<Object> DebugLookupResultValue(LookupIterator* it, 10879 static Handle<Object> DebugLookupResultValue(LookupIterator* it,
10880 bool* has_caught = NULL) { 10880 bool* has_caught = NULL) {
10881 for (; it->IsFound(); it->Next()) { 10881 for (; it->IsFound(); it->Next()) {
10882 switch (it->state()) { 10882 switch (it->state()) {
10883 case LookupIterator::NOT_FOUND: 10883 case LookupIterator::NOT_FOUND:
10884 case LookupIterator::TRANSITION:
10884 UNREACHABLE(); 10885 UNREACHABLE();
10885 case LookupIterator::ACCESS_CHECK: 10886 case LookupIterator::ACCESS_CHECK:
10886 // Ignore access checks. 10887 // Ignore access checks.
10887 break; 10888 break;
10888 case LookupIterator::INTERCEPTOR: 10889 case LookupIterator::INTERCEPTOR:
10889 case LookupIterator::JSPROXY: 10890 case LookupIterator::JSPROXY:
10890 return it->isolate()->factory()->undefined_value(); 10891 return it->isolate()->factory()->undefined_value();
10891 case LookupIterator::PROPERTY: 10892 case LookupIterator::PROPERTY:
10892 if (!it->HasProperty()) continue; 10893 if (!it->HasProperty()) continue;
10893 switch (it->property_kind()) { 10894 switch (it->property_kind()) {
(...skipping 4730 matching lines...) Expand 10 before | Expand all | Expand 10 after
15624 } 15625 }
15625 return NULL; 15626 return NULL;
15626 } 15627 }
15627 15628
15628 15629
15629 const Runtime::Function* Runtime::FunctionForId(Runtime::FunctionId id) { 15630 const Runtime::Function* Runtime::FunctionForId(Runtime::FunctionId id) {
15630 return &(kIntrinsicFunctions[static_cast<int>(id)]); 15631 return &(kIntrinsicFunctions[static_cast<int>(id)]);
15631 } 15632 }
15632 15633
15633 } } // namespace v8::internal 15634 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/stub-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698