Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 493683002: [CSS Grid Layout] Test coverage for column-* properties. (Closed)

Created:
6 years, 4 months ago by Sunil Ratnu
Modified:
6 years, 4 months ago
CC:
blink-reviews, jfernandez, Manuel Rego, svillar
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Grid Layout] Test coverage for column-* properties. According to the spec: all of the column-* properties in the Multicol module have no effect on a grid container. This was already working as expected but we were missing test for this. TEST:fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html BUG=395788 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180814

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporated review comments #

Total comments: 2

Patch Set 3 : Adding more content to show the bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
A LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container-expected.html View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
Sunil Ratnu
Please review this. Thanks!
6 years, 4 months ago (2014-08-20 14:59:14 UTC) #1
Julien - ping for review
lgtm https://codereview.chromium.org/493683002/diff/1/LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html File LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html (right): https://codereview.chromium.org/493683002/diff/1/LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html#newcode15 LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html:15: column-width: 1em; Let's get rid of the implicit ...
6 years, 4 months ago (2014-08-20 18:14:48 UTC) #2
Sunil Ratnu
https://codereview.chromium.org/493683002/diff/1/LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html File LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html (right): https://codereview.chromium.org/493683002/diff/1/LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html#newcode15 LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html:15: column-width: 1em; Thanks Julien for the review. I have ...
6 years, 4 months ago (2014-08-21 05:11:17 UTC) #3
Julien - ping for review
lgtm with more content to show the bug. https://codereview.chromium.org/493683002/diff/20001/LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html File LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html (right): https://codereview.chromium.org/493683002/diff/20001/LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html#newcode21 LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html:21: AAAAAAAAAA ...
6 years, 4 months ago (2014-08-21 15:23:49 UTC) #4
Sunil Ratnu
https://codereview.chromium.org/493683002/diff/20001/LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html File LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html (right): https://codereview.chromium.org/493683002/diff/20001/LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html#newcode21 LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html:21: AAAAAAAAAA BBBBBBBBBB On 2014/08/21 15:23:48, Julien Chaffraix - PST ...
6 years, 4 months ago (2014-08-22 04:57:30 UTC) #5
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-22 04:57:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/493683002/40001
6 years, 4 months ago (2014-08-22 04:58:07 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 05:54:55 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 05:58:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/8211)
6 years, 4 months ago (2014-08-22 05:58:23 UTC) #10
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-22 06:10:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/493683002/40001
6 years, 4 months ago (2014-08-22 06:10:32 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 06:13:16 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 06:15:43 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/8214)
6 years, 4 months ago (2014-08-22 06:15:45 UTC) #15
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-22 07:48:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/493683002/40001
6 years, 4 months ago (2014-08-22 07:49:00 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 07:52:00 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 07:56:09 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/8228)
6 years, 4 months ago (2014-08-22 07:56:10 UTC) #20
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-22 10:33:16 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/493683002/40001
6 years, 4 months ago (2014-08-22 10:34:04 UTC) #22
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 10:37:06 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 10:39:43 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/8265)
6 years, 4 months ago (2014-08-22 10:39:44 UTC) #25
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-23 04:51:45 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/493683002/40001
6 years, 4 months ago (2014-08-23 04:52:20 UTC) #27
commit-bot: I haz the power
6 years, 4 months ago (2014-08-24 04:53:50 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (40001) as 180814

Powered by Google App Engine
This is Rietveld 408576698