LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html - Issue 493683002: [CSS Grid Layout] Test coverage for column-* properties.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html

Issue 493683002: [CSS Grid Layout] Test coverage for column-* properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Incorporated review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <link href="resources/grid.css" rel="stylesheet">

	4 <style>

	5 .grid, .inline-grid

	6 {

	7 width: 20em;

	8 -webkit-column-count: 2; /* Chrome, Safari, Opera */

	9 -moz-column-count: 2; /* Firefox */

	10 column-count: 2;

	11

	12 -webkit-column-gap: 100px; /* Chrome, Safari, Opera */

	13 -moz-column-gap: 100px; /* Firefox */

	14 column-gap: 100px;

	15 }

	16 </style>

	17

	18 <body>

	19

	20 <div class='grid'>

	21 AAAAAAAAAA BBBBBBBBBB
	Julien - ping for review 2014/08/21 15:23:48 I would have left the content untouched. The reaso I would have left the content untouched. The reason is that if you don't have enough content to fill a second line in your multi-column, we wouldn't see the difference visually. Sunil Ratnu 2014/08/22 04:57:30 Done. Show quoted text On 2014/08/21 15:23:48, Julien Chaffraix - PST wrote: > I would have left the content untouched. The reason is that if you don't have > enough content to fill a second line in your multi-column, we wouldn't see the > difference visually. Done.
	22 </div>

	23

	24 <div class='inline-grid'>

	25 AAAAAAAAAA BBBBBBBBBB

	26 </div>

	27

	28 </body>

	29 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container-expected.html » ('j') | no next file with comments »