LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html - Issue 493683002: [CSS Grid Layout] Test coverage for column-* properties.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html

Issue 493683002: [CSS Grid Layout] Test coverage for column-* properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <link href="resources/grid.css" rel="stylesheet">

	4 <style>

	5 .grid

	6 {

	7 -webkit-column-width: 1em;

	8 -moz-column-width: 1em;

	9 column-width: 1em;

	10 }

	11 .inline-grid

	12 {

	13 -webkit-column-width: 1em;

	14 -moz-column-width: 1em;

	15 column-width: 1em;
	Julien - ping for review 2014/08/20 18:14:48 Let's get rid of the implicit assumption that the Let's get rid of the implicit assumption that the grid width is the viewport's by adding an explicit width here. I would also just set the column-count as it's easier to see what's going on (and avoids having a lot of columns). My take would be: width: 20em; column-count:2; (which would nicely split the content into 2 columns, thus showing the issue a lot more than a lot of columns). Sunil Ratnu 2014/08/21 05:11:17 Thanks Julien for the review. I have made the sugg Thanks Julien for the review. I have made the suggested changes. Also, 1. I have removed column-width property as column-count itself is sufficient enough. 2. Added column-gap so that this CL tests more than one column-* property as mentioned in the title. Please have an another look before commiting. On 2014/08/20 18:14:48, Julien Chaffraix - PST wrote: Show quoted text > Let's get rid of the implicit assumption that the grid width is the viewport's > by adding an explicit width here. I would also just set the column-count as it's > easier to see what's going on (and avoids having a lot of columns). > > My take would be: > width: 20em; > column-count:2; > > (which would nicely split the content into 2 columns, thus showing the issue a > lot more than a lot of columns).
	16 }

	17 </style>

	18

	19 <body>

	20

	21 <div class='grid'>

	22 AAAAAAAAAA BBBBBBBBBB CCCCCCCCCC DDDDDDDDD

	23 </div>

	24

	25 <div class='inline-grid'>

	26 AAAAAAAAAA BBBBBBBBBB CCCCCCCCCC DDDDDDDDD

	27 </div>

	28

	29 </body>

	30 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/column-property-should-not-apply-on-grid-container-expected.html » ('j') | no next file with comments »