[DevTools] Implement Inspector.interstitial events.

[DevTools] Implement Inspector.interstitial events.

BUG=404631
Committed: https://crrev.com/ef392e8ba668437a976a427ead97754450822030
Cr-Commit-Position: refs/heads/master@{#291629}

[dgozman, 2014-08-22 09:20:49]

Take a look please.

[pfeldman, 2014-08-22 13:08:46]

https://codereview.chromium.org/493213004/diff/1/content/browser/devtools/ren...
File content/browser/devtools/render_view_devtools_agent_host.cc (right):

https://codereview.chromium.org/493213004/diff/1/content/browser/devtools/ren...
content/browser/devtools/render_view_devtools_agent_host.cc:322:
overrides_handler_->DidAttachInterstitialPage();
One of the main protocol rules is that the domain is silent unless user requests
something. You should only issue this in case Inspector.enable (or Page.enable)
has been called depending on the domain notification belongs. I wonder if we
should move it to Page.* so that the client does not need to enable the
inspector domain just for that.

[dgozman, 2014-08-22 16:29:29]

PTAL

https://codereview.chromium.org/493213004/diff/1/content/browser/devtools/ren...
File content/browser/devtools/render_view_devtools_agent_host.cc (right):

https://codereview.chromium.org/493213004/diff/1/content/browser/devtools/ren...
content/browser/devtools/render_view_devtools_agent_host.cc:322:
overrides_handler_->DidAttachInterstitialPage();
On 2014/08/22 13:08:46, pfeldman wrote:
> One of the main protocol rules is that the domain is silent unless user
requests
> something. You should only issue this in case Inspector.enable (or
Page.enable)
> has been called depending on the domain notification belongs. I wonder if we
> should move it to Page.* so that the client does not need to enable the
> inspector domain just for that.

Done.

[pfeldman, 2014-08-22 16:57:09]

lgtm.

[dgozman, 2014-08-24 19:25:47]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-08-24 19:26:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/493213004/20001

[commit-bot: I haz the power, 2014-08-24 20:22:54]

Committed patchset #2 (20001) as 5dbb0fea3afcea841077ae9541433e69dd0171dd

[commit-bot: I haz the power, 2014-09-10 02:32:43]

Patchset 2 (id:??) landed as
https://crrev.com/ef392e8ba668437a976a427ead97754450822030
Cr-Commit-Position: refs/heads/master@{#291629}