Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: content/browser/devtools/renderer_overrides_handler.cc

Issue 493213004: [DevTools] Implement Inspector.interstitial events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/renderer_overrides_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/renderer_overrides_handler.cc
diff --git a/content/browser/devtools/renderer_overrides_handler.cc b/content/browser/devtools/renderer_overrides_handler.cc
index dff8d973836356fa847ce75c6056a7ef5fdab9c4..7d63a6f9bf9aac823a917c04612f1d78e0393763 100644
--- a/content/browser/devtools/renderer_overrides_handler.cc
+++ b/content/browser/devtools/renderer_overrides_handler.cc
@@ -72,7 +72,8 @@ static int kCaptureRetryLimit = 2;
} // namespace
RendererOverridesHandler::RendererOverridesHandler()
- : has_last_compositor_frame_metadata_(false),
+ : page_domain_enabled_(false),
+ has_last_compositor_frame_metadata_(false),
capture_retry_count_(0),
touch_emulation_enabled_(false),
color_picker_enabled_(false),
@@ -100,6 +101,10 @@ RendererOverridesHandler::RendererOverridesHandler()
&RendererOverridesHandler::ClearBrowserCookies,
base::Unretained(this)));
RegisterCommandHandler(
+ devtools::Page::enable::kName,
+ base::Bind(
+ &RendererOverridesHandler::PageEnable, base::Unretained(this)));
+ RegisterCommandHandler(
devtools::Page::disable::kName,
base::Bind(
&RendererOverridesHandler::PageDisable, base::Unretained(this)));
@@ -216,6 +221,16 @@ void RendererOverridesHandler::ClearRenderViewHost() {
ResetColorPickerFrame();
}
+void RendererOverridesHandler::DidAttachInterstitialPage() {
+ if (page_domain_enabled_)
+ SendNotification(devtools::Page::interstitialShown::kName, NULL);
+}
+
+void RendererOverridesHandler::DidDetachInterstitialPage() {
+ if (page_domain_enabled_)
+ SendNotification(devtools::Page::interstitialHidden::kName, NULL);
+}
+
void RendererOverridesHandler::InnerSwapCompositorFrame() {
if ((base::TimeTicks::Now() - last_frame_time_).InMilliseconds() <
kFrameRateThresholdMs) {
@@ -341,9 +356,19 @@ RendererOverridesHandler::ClearBrowserCookies(
// Page agent handlers -------------------------------------------------------
scoped_refptr<DevToolsProtocol::Response>
+RendererOverridesHandler::PageEnable(
+ scoped_refptr<DevToolsProtocol::Command> command) {
+ page_domain_enabled_ = true;
+ // Fall through to the renderer.
+ return NULL;
+}
+
+scoped_refptr<DevToolsProtocol::Response>
RendererOverridesHandler::PageDisable(
scoped_refptr<DevToolsProtocol::Command> command) {
+ page_domain_enabled_ = false;
OnClientDetached();
+ // Fall through to the renderer.
return NULL;
}
« no previous file with comments | « content/browser/devtools/renderer_overrides_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698