[DevTools] Implement Inspector.interstitial events.

content/browser/devtools/render_view_devtools_agent_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/render_view_devtools_agent_host.h"
 
 #include "base/basictypes.h"
 #include "base/lazy_instance.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/devtools/devtools_manager_impl.h"
@@ skipping 301 matching lines @@
     RenderFrameHost* render_frame_host) {
   return DispatchIPCMessage(message);
 }
 
 bool RenderViewDevToolsAgentHost::OnMessageReceived(
     const IPC::Message& message) {
   return DispatchIPCMessage(message);
 }
 
 void RenderViewDevToolsAgentHost::DidAttachInterstitialPage() {
+  overrides_handler_->DidAttachInterstitialPage();

[pfeldman, 2014/08/22 13:08:46]

One of the main protocol rules is that the domain is silent unless user requests
something. You should only issue this in case Inspector.enable (or Page.enable)
has been called depending on the domain notification belongs. I wonder if we
should move it to Page.* so that the client does not need to enable the
inspector domain just for that.

[dgozman, 2014/08/22 16:29:28]

Done.

+
   if (!render_view_host_)
     return;
   // The rvh set in AboutToNavigateRenderView turned out to be interstitial.
   // Connect back to the real one.
   WebContents* web_contents =
     WebContents::FromRenderViewHost(render_view_host_);
   if (!web_contents)
     return;
   DisconnectRenderViewHost();
   ConnectRenderViewHost(web_contents->GetRenderViewHost());
 }
 
+void RenderViewDevToolsAgentHost::DidDetachInterstitialPage() {
+  overrides_handler_->DidDetachInterstitialPage();
+}
+
 void RenderViewDevToolsAgentHost::Observe(int type,
                                           const NotificationSource& source,
                                           const NotificationDetails& details) {
   if (type == content::NOTIFICATION_RENDER_WIDGET_VISIBILITY_CHANGED) {
     bool visible = *Details<bool>(details).ptr();
     overrides_handler_->OnVisibilityChanged(visible);
   }
 }
 
 void RenderViewDevToolsAgentHost::SetRenderViewHost(RenderViewHost* rvh) {
@@ skipping 93 matching lines @@
   scoped_refptr<DevToolsProtocol::Notification> notification =
       DevToolsProtocol::ParseNotification(message);
 
   if (notification) {
     tracing_handler_->HandleNotification(notification);
   }
   SendMessageToClient(message);
 }
 
 }  // namespace content