Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 492433005: Get rid of the NONEXISTENT PropertyType (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Get rid of the NONEXISTENT PropertyType BUG= Committed: https://code.google.com/p/v8/source/detail?r=23260

Patch Set 1 #

Patch Set 2 : Fix lookupresult #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -36 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ic.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/lookup.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lookup.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mirror-debugger.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/objects-printer.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/property.h View 1 6 chunks +3 lines, -9 lines 0 comments Download
M src/property.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/property-details.h View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-20 11:34:48 UTC) #1
Yang
On 2014/08/20 11:34:48, Toon Verwaest wrote: > PTAL lgtm.
6 years, 4 months ago (2014-08-21 08:11:50 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-08-21 08:16:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 23260 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698