Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/lookup.cc

Issue 492433005: Get rid of the NONEXISTENT PropertyType (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix lookupresult Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/lookup.h ('k') | src/mirror-debugger.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/deoptimizer.h" 8 #include "src/deoptimizer.h"
9 #include "src/lookup.h" 9 #include "src/lookup.h"
10 #include "src/lookup-inl.h" 10 #include "src/lookup-inl.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 switch (property_details_.type()) { 93 switch (property_details_.type()) {
94 case v8::internal::FIELD: 94 case v8::internal::FIELD:
95 case v8::internal::NORMAL: 95 case v8::internal::NORMAL:
96 case v8::internal::CONSTANT: 96 case v8::internal::CONSTANT:
97 property_kind_ = DATA; 97 property_kind_ = DATA;
98 break; 98 break;
99 case v8::internal::CALLBACKS: 99 case v8::internal::CALLBACKS:
100 property_kind_ = ACCESSOR; 100 property_kind_ = ACCESSOR;
101 break; 101 break;
102 case v8::internal::HANDLER: 102 case v8::internal::HANDLER:
103 case v8::internal::NONEXISTENT:
104 case v8::internal::INTERCEPTOR: 103 case v8::internal::INTERCEPTOR:
105 UNREACHABLE(); 104 UNREACHABLE();
106 } 105 }
107 106
108 has_property_ = true; 107 has_property_ = true;
109 return true; 108 return true;
110 } 109 }
111 110
112 111
113 void LookupIterator::ReloadPropertyInformation() { 112 void LookupIterator::ReloadPropertyInformation() {
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 DCHECK_EQ(v8::internal::CONSTANT, property_details_.type()); 346 DCHECK_EQ(v8::internal::CONSTANT, property_details_.type());
348 } 347 }
349 } 348 }
350 349
351 350
352 void LookupIterator::InternalizeName() { 351 void LookupIterator::InternalizeName() {
353 if (name_->IsUniqueName()) return; 352 if (name_->IsUniqueName()) return;
354 name_ = factory()->InternalizeString(Handle<String>::cast(name_)); 353 name_ = factory()->InternalizeString(Handle<String>::cast(name_));
355 } 354 }
356 } } // namespace v8::internal 355 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/lookup.h ('k') | src/mirror-debugger.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698