Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: src/heap-snapshot-generator.cc

Issue 492433005: Get rid of the NONEXISTENT PropertyType (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix lookupresult Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/bootstrapper.cc ('k') | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/heap-snapshot-generator-inl.h" 7 #include "src/heap-snapshot-generator-inl.h"
8 8
9 #include "src/allocation-tracker.h" 9 #include "src/allocation-tracker.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1682 matching lines...) Expand 10 before | Expand all | Expand 10 after
1693 break; 1693 break;
1694 case CALLBACKS: 1694 case CALLBACKS:
1695 ExtractAccessorPairProperty( 1695 ExtractAccessorPairProperty(
1696 js_obj, entry, 1696 js_obj, entry,
1697 descs->GetKey(i), descs->GetValue(i)); 1697 descs->GetKey(i), descs->GetValue(i));
1698 break; 1698 break;
1699 case NORMAL: // only in slow mode 1699 case NORMAL: // only in slow mode
1700 case HANDLER: // only in lookup results, not in descriptors 1700 case HANDLER: // only in lookup results, not in descriptors
1701 case INTERCEPTOR: // only in lookup results, not in descriptors 1701 case INTERCEPTOR: // only in lookup results, not in descriptors
1702 break; 1702 break;
1703 case NONEXISTENT:
1704 UNREACHABLE();
1705 break;
1706 } 1703 }
1707 } 1704 }
1708 } else { 1705 } else {
1709 NameDictionary* dictionary = js_obj->property_dictionary(); 1706 NameDictionary* dictionary = js_obj->property_dictionary();
1710 int length = dictionary->Capacity(); 1707 int length = dictionary->Capacity();
1711 for (int i = 0; i < length; ++i) { 1708 for (int i = 0; i < length; ++i) {
1712 Object* k = dictionary->KeyAt(i); 1709 Object* k = dictionary->KeyAt(i);
1713 if (dictionary->IsKey(k)) { 1710 if (dictionary->IsKey(k)) {
1714 Object* target = dictionary->ValueAt(i); 1711 Object* target = dictionary->ValueAt(i);
1715 // We assume that global objects can only have slow properties. 1712 // We assume that global objects can only have slow properties.
(...skipping 1451 matching lines...) Expand 10 before | Expand all | Expand 10 after
3167 writer_->AddString("\"<dummy>\""); 3164 writer_->AddString("\"<dummy>\"");
3168 for (int i = 1; i < sorted_strings.length(); ++i) { 3165 for (int i = 1; i < sorted_strings.length(); ++i) {
3169 writer_->AddCharacter(','); 3166 writer_->AddCharacter(',');
3170 SerializeString(sorted_strings[i]); 3167 SerializeString(sorted_strings[i]);
3171 if (writer_->aborted()) return; 3168 if (writer_->aborted()) return;
3172 } 3169 }
3173 } 3170 }
3174 3171
3175 3172
3176 } } // namespace v8::internal 3173 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698