Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: chrome/browser/extensions/api/declarative_content/content_action.cc

Issue 491913003: Add Reapply() to declarative action interface. This is needed for RequestContentScript to work corr… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_content/content_action.cc
diff --git a/chrome/browser/extensions/api/declarative_content/content_action.cc b/chrome/browser/extensions/api/declarative_content/content_action.cc
index 298f504fd257a7c23c8f6f59c904b9382ccac3c7..01980f94a9d796b66b1da80c6f50633849e3924f 100644
--- a/chrome/browser/extensions/api/declarative_content/content_action.cc
+++ b/chrome/browser/extensions/api/declarative_content/content_action.cc
@@ -80,6 +80,9 @@ class ShowPageAction : public ContentAction {
action, apply_info->tab);
}
}
+ virtual void Reapply(const std::string& extension_id,
not at google - send to devlin 2014/08/21 00:32:56 Ditto, and add comment like, // The page action i
Mark Dittmer 2014/08/21 01:08:48 Done.
+ const base::Time& extension_install_time,
+ ApplyInfo* apply_info) const OVERRIDE {}
private:
static ExtensionAction* GetPageAction(Profile* profile,
@@ -132,6 +135,13 @@ class RequestContentScript : public ContentAction {
// do not load user script if Apply() runs again on the same page.
}
+ virtual void Reapply(const std::string& extension_id,
not at google - send to devlin 2014/08/21 00:32:56 Ditto (ordering).
Mark Dittmer 2014/08/21 01:08:48 Done.
+ const base::Time& extension_install_time,
+ ApplyInfo* apply_info) const OVERRIDE {
+ // TODO(markdittmer): Invoke UserScriptMaster declarative script loader:
+ // load new user script.
+ }
+
private:
virtual ~RequestContentScript() {}

Powered by Google App Engine
This is Rietveld 408576698