Add Reapply() to declarative action interface. This is needed for RequestContentScript to work corr…

chrome/browser/extensions/api/declarative_content/content_action.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative_content/content_action.h"
 
 #include <map>
 
 #include "base/lazy_instance.h"
 #include "base/strings/stringprintf.h"
@@ skipping 62 matching lines @@
   virtual void Revert(const std::string& extension_id,
                       const base::Time& extension_install_time,
                       ApplyInfo* apply_info) const OVERRIDE {
     if (ExtensionAction* action =
             GetPageAction(apply_info->profile, extension_id)) {
       action->UndoDeclarativeShow(ExtensionTabUtil::GetTabId(apply_info->tab));
       ExtensionActionAPI::Get(apply_info->profile)->NotifyChange(
           action, apply_info->tab);
     }
   }
+  virtual void Reapply(const std::string& extension_id,

[not at google - send to devlin, 2014/08/21 00:32:56]

Ditto, and add comment like,

// The page action is already showing, so nothing needs to be done here.

[Mark Dittmer, 2014/08/21 01:08:48]

Done.

+                       const base::Time& extension_install_time,
+                       ApplyInfo* apply_info) const OVERRIDE {}
 
  private:
   static ExtensionAction* GetPageAction(Profile* profile,
                                         const std::string& extension_id) {
     const Extension* extension =
         ExtensionRegistry::Get(profile)
             ->GetExtensionById(extension_id, ExtensionRegistry::EVERYTHING);
     if (!extension)
       return NULL;
     return ExtensionActionManager::Get(profile)->GetPageAction(*extension);
@@ skipping 32 matching lines @@
     // load new user script.
   }
 
   virtual void Revert(const std::string& extension_id,
                       const base::Time& extension_install_time,
                       ApplyInfo* apply_info) const OVERRIDE {
     // TODO(markdittmer): Invoke UserScriptMaster declarative script loader:
     // do not load user script if Apply() runs again on the same page.
   }
 
+  virtual void Reapply(const std::string& extension_id,

[not at google - send to devlin, 2014/08/21 00:32:56]

Ditto (ordering).

[Mark Dittmer, 2014/08/21 01:08:48]

Done.

+                       const base::Time& extension_install_time,
+                       ApplyInfo* apply_info) const OVERRIDE {
+    // TODO(markdittmer): Invoke UserScriptMaster declarative script loader:
+    // load new user script.
+  }
+
  private:
   virtual ~RequestContentScript() {}
 
   std::vector<std::string> css_file_names_;
   std::vector<std::string> js_file_names_;
   bool all_frames_;
   bool match_about_blank_;
 
   DISALLOW_COPY_AND_ASSIGN(RequestContentScript);
 };
@@ skipping 111 matching lines @@
       factory_method_iter = factory.factory_methods.find(instance_type);
   if (factory_method_iter != factory.factory_methods.end())
     return (*factory_method_iter->second)(
         extension, action_dict, error, bad_message);
 
   *error = base::StringPrintf(kInvalidInstanceTypeError, instance_type.c_str());
   return scoped_refptr<ContentAction>();
 }
 
 }  // namespace extensions