chrome/browser/extensions/api/declarative_content/content_rules_registry.cc - Issue 491913003: Add Reapply() to declarative action interface. This is needed for RequestContentScript to work corr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/content_rules_registry.cc

Issue 491913003: Add Reapply() to declarative action interface. This is needed for RequestContentScript to work corr… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative_content/content_action.cc ('K') | « chrome/browser/extensions/api/declarative_content/content_action.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/content_rules_registry.cc

diff --git a/chrome/browser/extensions/api/declarative_content/content_rules_registry.cc b/chrome/browser/extensions/api/declarative_content/content_rules_registry.cc

index 7b379c1a67f2eeade2c708a517bd25de1713f5a7..3f481abb76bc77185d827cfee34f5dd1b929ad92 100644

--- a/chrome/browser/extensions/api/declarative_content/content_rules_registry.cc

+++ b/chrome/browser/extensions/api/declarative_content/content_rules_registry.cc

@@ -82,6 +82,9 @@ void ContentRulesRegistry::Apply(

it != matching_rules.end(); ++it) {

if (!ContainsKey(prev_matching_rules, *it))

(*it)->actions().Apply((*it)->extension_id(), base::Time(), &apply_info);

+ else

+ (*it)->actions().Reapply(

+ (*it)->extension_id(), base::Time(), &apply_info);

not at google - send to devlin 2014/08/21 00:32:56 Nit: this body is 2 lines, so it should be inside

Mark Dittmer 2014/08/21 01:08:48 Done.

}

for (std::set<ContentRule*>::const_iterator it = prev_matching_rules.begin();

it != prev_matching_rules.end(); ++it) {