Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1590)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 491913003: Add Reapply() to declarative action interface. This is needed for RequestContentScript to work corr… (Closed)

Created:
6 years, 4 months ago by Mark Dittmer
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add Reapply() to declarative action interface. This is needed for RequestContentScript to work correctly from one matching page to the next. BUG=377978 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291094

Patch Set 1 #

Total comments: 12

Patch Set 2 : Fixed nits. Mostly order of presentation. #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M chrome/browser/extensions/api/declarative/declarative_rule.h View 1 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_action.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_action.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_rules_registry.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
not at google - send to devlin
lgtm with pretty much the same nit over and over. https://codereview.chromium.org/491913003/diff/1/chrome/browser/extensions/api/declarative/declarative_rule.h File chrome/browser/extensions/api/declarative/declarative_rule.h (right): https://codereview.chromium.org/491913003/diff/1/chrome/browser/extensions/api/declarative/declarative_rule.h#newcode168 ...
6 years, 4 months ago (2014-08-21 00:32:57 UTC) #1
Mark Dittmer
Fixed nits. Mostly order of presentation. https://codereview.chromium.org/491913003/diff/1/chrome/browser/extensions/api/declarative/declarative_rule.h File chrome/browser/extensions/api/declarative/declarative_rule.h (right): https://codereview.chromium.org/491913003/diff/1/chrome/browser/extensions/api/declarative/declarative_rule.h#newcode168 chrome/browser/extensions/api/declarative/declarative_rule.h:168: void Reapply(const std::string& ...
6 years, 4 months ago (2014-08-21 01:08:48 UTC) #2
Mark Dittmer
The CQ bit was checked by markdittmer@chromium.org
6 years, 4 months ago (2014-08-21 01:08:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markdittmer@chromium.org/491913003/20001
6 years, 4 months ago (2014-08-21 01:10:55 UTC) #4
Mark Dittmer
The CQ bit was checked by markdittmer@chromium.org
6 years, 4 months ago (2014-08-21 02:12:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markdittmer@chromium.org/491913003/40001
6 years, 4 months ago (2014-08-21 02:12:47 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 03:35:52 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 03:57:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/4069)
6 years, 4 months ago (2014-08-21 03:57:37 UTC) #9
Mark Dittmer
The CQ bit was checked by markdittmer@chromium.org
6 years, 4 months ago (2014-08-21 12:00:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markdittmer@chromium.org/491913003/60001
6 years, 4 months ago (2014-08-21 12:01:02 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 16:36:10 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 (60001) as 291094

Powered by Google App Engine
This is Rietveld 408576698