chrome/browser/extensions/api/declarative_content/content_action.h - Issue 491913003: Add Reapply() to declarative action interface. This is needed for RequestContentScript to work corr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/content_action.h

Issue 491913003: Add Reapply() to declarative action interface. This is needed for RequestContentScript to work corr… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase again Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/declarative_rule.h ('k') | chrome/browser/extensions/api/declarative_content/content_action.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/content_action.h

diff --git a/chrome/browser/extensions/api/declarative_content/content_action.h b/chrome/browser/extensions/api/declarative_content/content_action.h

index bb18d02996bbf21e3d3cd319d03c1498e00b9ebe..347cf53e86a47956373354367c6e66c7847753b5 100644

--- a/chrome/browser/extensions/api/declarative_content/content_action.h

+++ b/chrome/browser/extensions/api/declarative_content/content_action.h

@@ -45,10 +45,14 @@ class ContentAction : public base::RefCounted<ContentAction> {

// Applies or reverts this ContentAction on a particular tab for a particular

// extension. Revert exists to keep the actions up to date as the page

- // changes.

+ // changes. Reapply exists to reapply changes to a new page, even if the

+ // previous page also matched relevant conditions.

virtual void Apply(const std::string& extension_id,

const base::Time& extension_install_time,

ApplyInfo* apply_info) const = 0;

+ virtual void Reapply(const std::string& extension_id,

+ const base::Time& extension_install_time,

+ ApplyInfo* apply_info) const = 0;

virtual void Revert(const std::string& extension_id,

const base::Time& extension_install_time,

ApplyInfo* apply_info) const = 0;