Issue 491063002: rebaseline_server: if creating brand new expectations files, include the header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 491063002: rebaseline_server: if creating brand new expectations files, include the header (Closed)

Created:
6 years, 4 months ago by epoger

Modified:
6 years, 4 months ago

Reviewers:
stephana

CC:
reviews_skia.org, rmistry

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

rebaseline_server: if creating brand new expectations files, include the header Otherwise, the first time you compare against these expectations, you get failures. NOTREECHECKS=true NOTRY=true TBR=stephana Committed: https://skia.googlesource.com/skia/+/1a17f7aeb2c735db64c977e2dd7910b00afc23a5

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	gm/rebaseline_server/compare_rendered_pictures.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	gm/rebaseline_server/writable_expectations.py	View		1 chunk	+9 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/491063002/1

6 years, 4 months ago (2014-08-20 18:39:26 UTC) #3

commit-bot: I haz the power

6 years, 4 months ago (2014-08-20 18:39:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 1a17f7aeb2c735db64c977e2dd7910b00afc23a5