Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: gm/rebaseline_server/writable_expectations.py

Issue 491063002: rebaseline_server: if creating brand new expectations files, include the header (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/rebaseline_server/compare_rendered_pictures.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/rebaseline_server/writable_expectations.py
diff --git a/gm/rebaseline_server/writable_expectations.py b/gm/rebaseline_server/writable_expectations.py
index dada0358c7c6b2a22a32034c56b6f58ec6cb0ad5..09b9cf76896906786b2e86861201778c437f26ca 100644
--- a/gm/rebaseline_server/writable_expectations.py
+++ b/gm/rebaseline_server/writable_expectations.py
@@ -79,7 +79,15 @@ class WritableExpectations(git_utils.NewGitCheckout):
# Make sure we have expected-results sections in all our output dicts.
for pathname, adict in dicts.iteritems():
if not adict:
- adict = {}
+ adict = {
+ # TODO(stephana): These values should be defined as constants
+ # somewhere, to be kept in sync between this file and
+ # compare_rendered_pictures.py.
+ gm_json.JSONKEY_HEADER: {
+ gm_json.JSONKEY_HEADER_TYPE: 'ChecksummedImages',
+ gm_json.JSONKEY_HEADER_REVISION: 1,
+ }
+ }
if not adict.get(gm_json.JSONKEY_EXPECTEDRESULTS, None):
adict[gm_json.JSONKEY_EXPECTEDRESULTS] = {}
dicts[pathname] = adict
« no previous file with comments | « gm/rebaseline_server/compare_rendered_pictures.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698