gm/rebaseline_server/compare_rendered_pictures.py - Issue 491063002: rebaseline_server: if creating brand new expectations files, include the header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/compare_rendered_pictures.py

Issue 491063002: rebaseline_server: if creating brand new expectations files, include the header (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/rebaseline_server/compare_rendered_pictures.py

diff --git a/gm/rebaseline_server/compare_rendered_pictures.py b/gm/rebaseline_server/compare_rendered_pictures.py

index a6e0aa0bc54e3d33e84d522d44c690854c036d46..cf0fa228b7092cdeb4316b99001d298b9fce1a8e 100755

--- a/gm/rebaseline_server/compare_rendered_pictures.py

+++ b/gm/rebaseline_server/compare_rendered_pictures.py

@@ -351,6 +351,8 @@ class RenderedPicturesComparisons(results.BaseComparisons):

result_dict: dictionary holding output of render_pictures; if None,

this method will return without raising an Exception

"""

+ # TODO(stephana): These values should be defined as constants somewhere,

+ # to be kept in sync between this file and writable_expectations.py

expected_header_type = 'ChecksummedImages'

expected_header_revision = 1

« no previous file with comments | « no previous file | gm/rebaseline_server/writable_expectations.py » ('j') | no next file with comments »