Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 49049: Workaround a SafeBrowsingBlockingPage crasher (Closed)

Created:
11 years, 9 months ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
Paul Godavari
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

A crash report from the field reports that we are removing a SafeBrowsingBlockingPage from a global map that is not to be found causing a stl exception to be thrown. I am not sure what the cause is yet, my investigations results are in the bug comment. This is a work-around the crasher while I keep investigating. BUG=9442 TEST=Access a page which contains sub-resource malware. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12732

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/tab_contents/interstitial_page.cc View 1 chunk +5 lines, -2 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
jcampan
11 years, 9 months ago (2009-03-28 01:28:47 UTC) #1
Paul Godavari
http://codereview.chromium.org/49049/diff/1/2 File chrome/browser/tab_contents/interstitial_page.cc (right): http://codereview.chromium.org/49049/diff/1/2#newcode133 Line 133: tab_to_interstitial_page_->erase(iter); LGTM. Could this be due to multiple ...
11 years, 9 months ago (2009-03-28 01:34:53 UTC) #2
jcampan
11 years, 9 months ago (2009-03-28 01:42:22 UTC) #3
http://codereview.chromium.org/49049/diff/1/2
File chrome/browser/tab_contents/interstitial_page.cc (right):

http://codereview.chromium.org/49049/diff/1/2#newcode133
Line 133: tab_to_interstitial_page_->erase(iter);
On 2009/03/28 01:34:54, Paul Godavari wrote:
> LGTM.
> 
> Could this be due to multiple malware resources on the same page causing a
> second interstitial to be shown or added to the list of resources on the first
> interstitial page?

Shouldn't be the case anymore. I added some code few months ago to deal with
these exact cases. It queues interstitials if more than one is displayed.

Powered by Google App Engine
This is Rietveld 408576698