Workaround a SafeBrowsingBlockingPage crasher

chrome/browser/tab_contents/interstitial_page.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/interstitial_page.h"
 
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
 #include "base/thread.h"
 #include "chrome/browser/browser.h"
@@ skipping 108 matching lines @@
   InitInterstitialPageMap();
   // It would be inconsistent to create an interstitial with no new navigation
   // (which is the case when the interstitial was triggered by a sub-resource on
   // a page) when we have a pending entry (in the process of loading a new top
   // frame).
   DCHECK(new_navigation || !tab->controller()->GetPendingEntry());
 }
 
 InterstitialPage::~InterstitialPage() {
   InterstitialPageMap::iterator iter = tab_to_interstitial_page_->find(tab_);
-  DCHECK(iter != tab_to_interstitial_page_->end());
-  tab_to_interstitial_page_->erase(iter);
+  DCHECK(iter != tab_to_interstitial_page_->end()) <<
+      "InterstitialPage missing from map. Please add a comment to the bug "
+      "http://crbug.com/9442 with the URL you were visiting";
+  if (iter != tab_to_interstitial_page_->end())
+    tab_to_interstitial_page_->erase(iter);

[Paul Godavari, 2009/03/28 01:34:54]

LGTM.

Could this be due to multiple malware resources on the same page causing a
second interstitial to be shown or added to the list of resources on the first
interstitial page?

[jcampan, 2009/03/28 01:42:22]

Shouldn't be the case anymore. I added some code few months ago to deal with
these exact cases. It queues interstitials if more than one is displayed.

   DCHECK(!render_view_host_);
 }
 
 void InterstitialPage::Show() {
   // If an interstitial is already showing, close it before showing the new one.
   if (tab_->interstitial_page())
     tab_->interstitial_page()->DontProceed();
 
   // Block the resource requests for the render view host while it is hidden.
   TakeActionOnResourceDispatcher(BLOCK);
@@ skipping 341 matching lines @@
 void InterstitialPage::InterstitialPageRVHViewDelegate::HandleKeyboardEvent(
     const NativeWebKeyboardEvent& event) {
   if (interstitial_page_->tab() && interstitial_page_->tab()->GetViewDelegate())
     interstitial_page_->tab()->GetViewDelegate()->HandleKeyboardEvent(event);
 }
 
 void InterstitialPage::InterstitialPageRVHViewDelegate::OnFindReply(
     int request_id, int number_of_matches, const gfx::Rect& selection_rect,
     int active_match_ordinal, bool final_update) {
 }