Workaround a SafeBrowsingBlockingPage crasher

chrome/browser/tab_contents/interstitial_page.cc

Index: chrome/browser/tab_contents/interstitial_page.cc
===================================================================
--- chrome/browser/tab_contents/interstitial_page.cc	(revision 12710)
+++ chrome/browser/tab_contents/interstitial_page.cc	(working copy)
@@ -126,8 +126,11 @@
 
 InterstitialPage::~InterstitialPage() {
   InterstitialPageMap::iterator iter = tab_to_interstitial_page_->find(tab_);
-  DCHECK(iter != tab_to_interstitial_page_->end());
-  tab_to_interstitial_page_->erase(iter);
+  DCHECK(iter != tab_to_interstitial_page_->end()) <<
+      "InterstitialPage missing from map. Please add a comment to the bug "
+      "http://crbug.com/9442 with the URL you were visiting";
+  if (iter != tab_to_interstitial_page_->end())
+    tab_to_interstitial_page_->erase(iter);

[Paul Godavari, 2009/03/28 01:34:54]

LGTM.

Could this be due to multiple malware resources on the same page causing a
second interstitial to be shown or added to the list of resources on the first
interstitial page?

[jcampan, 2009/03/28 01:42:22]

Shouldn't be the case anymore. I added some code few months ago to deal with
these exact cases. It queues interstitials if more than one is displayed.

   DCHECK(!render_view_host_);
 }