Source/modules/geolocation/GeolocationController.h - Issue 490143002: Move GeolocationClient to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/GeolocationController.h

Issue 490143002: Move GeolocationClient to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Provide default empty impl of WebGeolocationClient::geolocationDestroyed() virtual Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/geolocation/GeolocationController.h

diff --git a/Source/modules/geolocation/GeolocationController.h b/Source/modules/geolocation/GeolocationController.h

index e50da4645eb490c40df6af4e5305a5fac1e7e878..314819dc63d340412a9ab534a8426a126497c337 100644

--- a/Source/modules/geolocation/GeolocationController.h

+++ b/Source/modules/geolocation/GeolocationController.h

@@ -71,7 +71,6 @@ public:

// Inherited from Supplement.

virtual void trace(Visitor*) OVERRIDE;

- virtual void willBeDestroyed() OVERRIDE;

virtual void persistentHostHasBeenDestroyed() OVERRIDE;

private:

@@ -80,9 +79,7 @@ private:

void startUpdatingIfNeeded();

void stopUpdatingIfNeeded();

- void detach();

- GeolocationClient* m_client;

+ RawPtrWillBeMember<GeolocationClient> m_client;

bool m_hasClientForTest;

PersistentWillBeMember<GeolocationPosition> m_lastPosition;